Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore twitter link in html tests #3158

Merged
merged 1 commit into from
May 17, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented May 16, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax gongmax marked this pull request as ready for review May 16, 2023 22:32
@google-oss-prow google-oss-prow bot requested a review from markmandel May 16, 2023 22:32
@roberthbailey
Copy link
Member

@markmandel FYI (in case we want to try and revert this later)

The html site tests are currently failing trying to follow our link to the agones twitter account. While twitter seems to load just fine in a web browser, running curl against it ends up in a redirect loop:

$ curl -L https://twitter.com/agonesdev
curl: (47) Maximum (50) redirects followed
```

Since this is blocking CI, we are going to merge this to make sure that we can get other changes in and that we can cut a release next week. 

@roberthbailey
Copy link
Member

Unit tests passed (e2e tests were cancelled). I'm going to merge this so that de-flaking efforts can focus on e2e testing and not the strange twitter redirect loop.

@roberthbailey roberthbailey merged commit c7745fa into googleforgames:main May 17, 2023
@roberthbailey roberthbailey changed the title ignore twitter link in tests Ignore twitter link in html tests May 17, 2023
@roberthbailey roberthbailey added kind/bug These are bugs. area/site The website itself - including redirects, styling, search, etc labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/site The website itself - including redirects, styling, search, etc kind/bug These are bugs. lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants