Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress full e2e logs so the per-configuration links are obvious #3164

Merged
merged 1 commit into from
May 19, 2023
Merged

Suppress full e2e logs so the per-configuration links are obvious #3164

merged 1 commit into from
May 19, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented May 18, 2023 •
edited
Loading

Suppress gcloud builds submit logs - this should make it more obvious where to find the separate e2e logs and which configuration is failing.

Example failure: https://console.cloud.google.com/cloud-build/builds/03e89a9d-2e47-4ce2-8847-29f2f0820b60;step=24?jsmode=o&mods=logs_tg_prod&project=agones-images

Towards #3010

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2b2c7ecd-023a-4072-950f-c41f67d46d2f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3164/head:pr_3164 && git checkout pr_3164
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-edfc9ad-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6b685bbd-4f72-4432-b7f7-778e28c8a038

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn zmerlynn force-pushed the links-to-e2es branch 2 times, most recently from 31f2d54 to a2a0df6 Compare May 19, 2023 17:01
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5c30ac3d-d97f-4fbf-9928-33f1429c4615

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ac2a6e88-bea4-4d62-8ac4-42308c62396e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 03e89a9d-2e47-4ce2-8847-29f2f0820b60

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn zmerlynn changed the title Try just suppressing logs to make links more obvious Suppress full e2e logs so the per-configuration links are obvious May 19, 2023
@zmerlynn
Suppress logs to make links more obvious
189e74e 
With our per-configuration sub-builds, it's easier to go to the
per-configuration log than it is look at the firehose of interleaved
logs. Suppress the logs at the top level.

Alogn the way, enable line-oriented buffering using `stdbuf` so output
streams well - if we don't and e2es fail, the other e2e log links
aren't even printed.
@zmerlynn zmerlynn marked this pull request as ready for review May 19, 2023 18:32
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c43ac6ca-8f7e-4d42-80e7-53608eb6e336

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3164/head:pr_3164 && git checkout pr_3164
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-189e74e-amd64

@google-oss-prow google-oss-prow bot added the lgtm label May 19, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax gongmax merged commit edb7210 into googleforgames:main May 19, 2023
@Kalaiselvi84 Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@markmandel markmandel Awaiting requested review from markmandel

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@gongmax gongmax

Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmerlynn @agones-bot @gongmax @Kalaiselvi84