Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen the warning about reusing certificates in the yaml installation. #3167

Merged
merged 1 commit into from
May 20, 2023

Conversation

roberthbailey
Copy link
Member

Also clarify the instructions a bit.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #1064

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 08dac6da-130e-49e6-a9e9-4a91cf491a76

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true failed on my documentation PR, which is clearly a flake. Restarting the e2e tests to see if I can get a clean run.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d8449e31-0866-4cbe-bda3-b256150126c6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn
Copy link
Collaborator

This time it flaked on a unit test, TestControllerAllocator. :/

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

installation and clarify the instructions.
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label May 19, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 436a5236-b53d-4142-865d-e97a1ecec959

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3167/head:pr_3167 && git checkout pr_3167
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-b8260b4-amd64

@roberthbailey roberthbailey merged commit d50ab24 into googleforgames:main May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the installation security by replacing TLS certificates
4 participants