Fix bug: Disabled health checking not implemented #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/bug
|
Build Succeeded 👏 Build Id: 47566091-5c15-40fc-bbfc-f3138c72abf2 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
EricFortin
reviewed
Aug 14, 2018
pkg/gameservers/sdkserver_test.go
Outdated
| @@ -157,7 +171,7 @@ func TestSidecarHealthLastUpdated(t *testing.T) { | |||
|
|
|||
| sc, err := defaultSidecar(m) | |||
| assert.Nil(t, err) | |||
| sc.healthDisabled = false | |||
| sc.health = v1alpha1.Health{Disabled: true} | |||
There was a problem hiding this comment.
Doesn't it change the intent of the test?
There was a problem hiding this comment.
Ooh! Good catch 👍 Lemme check that one out!
There was a problem hiding this comment.
Fixed! Incoming shortly.
markmandel
force-pushed
the
bug/disabled-health
branch
from
a715fc9
to
c0b5c72
Compare
|
Build Failed 😱 Build Id: 07db5664-78d0-4617-abdd-8881ea6f37b2 Build Logs |
This commit fixes actually two bugs: 1) While we documented that you could disabled health checking we never actually implemented it! This fixes that. Thankfully, the work that has been done to retrieve `GameServer` details through the SDK makes this relatively easy. 2) SDK Server sidecar never had the necessary RBAC permissions to send events to the `GameServer` CRD. This is now fixed as well.
markmandel
force-pushed
the
bug/disabled-health
branch
from
c0b5c72
to
5da96b3
Compare
|
Build Succeeded 👏 Build Id: 85ababe5-a4c5-487a-90dd-f8ac1bf9e9e0 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
EricFortin
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes actually two bugs:
While we documented that you could disabled health checking we never
actually implemented it! This fixes that. Thankfully, the work that has been
done to retrieve
GameServerdetails through the SDK makes this relativelyeasy.
SDK Server sidecar never had the necessary RBAC permissions to send events
to the
GameServerCRD. This is now fixed as well.