Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label changes for service-monitor #3201

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

chiayi
Copy link
Contributor

@chiayi chiayi commented Jun 5, 2023

This changes service-monitor to match against the "extensions" label when SplitControllerAndExtensions is enabled. \

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
This is potential fix for #3190

Which issue(s) this PR fixes:
For #3190

Special notes for your reviewer:

@chiayi
Copy link
Contributor Author

chiayi commented Jun 5, 2023

Currently looking into exactly what metrics we will be missing if we do move the labelmatching.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 99f1b28a-5162-4c84-823c-5986ffff203f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 576ad7ea-4b9b-4262-b957-77adfd8e292c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3201/head:pr_3201 && git checkout pr_3201
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-d5c2459-amd64

@markmandel
Copy link
Member

Just wanted to check in, see if this needed any additional attention to help move it along.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiayi, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chiayi chiayi marked this pull request as ready for review June 20, 2023 20:23
@google-oss-prow google-oss-prow bot requested a review from aLekSer June 20, 2023 20:23
@zmerlynn zmerlynn enabled auto-merge (squash) June 20, 2023 21:11
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: beeae07e-ea2b-41e2-af0a-e31a9020b42c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3201/head:pr_3201 && git checkout pr_3201
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-2882677-amd64

@zmerlynn zmerlynn merged commit e6186c4 into googleforgames:main Jun 20, 2023
1 check passed
@Kalaiselvi84 Kalaiselvi84 added the kind/bug These are bugs. label Jun 25, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: de895adf-16de-443c-9073-b65501ef2c46

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants