Add Minikube instructions #321

slartibaartfast · 2018-08-14T19:07:46Z

Add Minikube instructions to edit_first_game_server.md

googlebot · 2018-08-14T19:07:49Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

slartibaartfast · 2018-08-14T19:11:50Z

Signed the thing

googlebot · 2018-08-14T19:11:52Z

CLAs look good, thanks!

agones-bot · 2018-08-14T19:15:18Z

Build Succeeded 👏

Build Id: 640776c7-5fa9-4151-ad05-5dbed299124a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.4.0-7ba5b5d
image: gcr.io/agones-images/agones-sdk:0.4.0-7ba5b5d
Linux C++ SDK (build: dev): agonessdk-0.4.0-7ba5b5d-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.4.0-7ba5b5d-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.4.0-7ba5b5d-src.zip
SDK Server: agonessdk-server-0.4.0-7ba5b5d.zip

(experimental) To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/321/head:pr_321 && git checkout pr_321
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.4.0-7ba5b5d

agones-bot · 2018-08-14T19:21:42Z

Build Succeeded 👏

Build Id: 217a8149-057f-42ea-a061-79a60b423d0e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.4.0-5f96c13
image: gcr.io/agones-images/agones-sdk:0.4.0-5f96c13
Linux C++ SDK (build: dev): agonessdk-0.4.0-5f96c13-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.4.0-5f96c13-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.4.0-5f96c13-src.zip
SDK Server: agonessdk-server-0.4.0-5f96c13.zip

(experimental) To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/321/head:pr_321 && git checkout pr_321
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.4.0-5f96c13

markmandel

Overall, this looks great 🎉

Had some thoughts/questions below, lemme know what you think!

Thanks!!!

markmandel · 2018-08-14T19:19:32Z

docs/edit_first_game_server.md

+
+To install on GKE, follow the install instructions (if you haven't already) at [Install and configure Agones on Kubernetes](../install/README.md). At least, you should have "Setting up a Google Kubernetes Engine (GKE) cluster", "Enabling creation of RBAC resources" and "Installing Agones" done.
+
+To install locally on Minikube, read [Developing, Testing, and Building Agones](../build/README.md) making sure to follow the instructions in the [Running A Test Minikube cluster](../build/README.md#running-a-test-minikube-cluster) section.


Should we link to installing on Minikube instead?
https://github.com/GoogleCloudPlatform/agones/blob/master/install/README.md#setting-up-a-minikube-cluster

Pros seem to be that it is less complex and requires less reading time.
Cons are that the reader is left to discover build tools on their own, and they might need information about having the project on their gopath.

So I would argue that if they are developing with Agones - they shouldn't need the build tools - they should install and use Agones as per normal.

I'm very hesitant to have the streams of using Agones and Developing Agones mix - they have very different targets, and it could get super messy in the long term.

Per your suggestion, this now links to https://github.com/GoogleCloudPlatform/agones/blob/master/install/README.md#setting-up-a-minikube-cluster

markmandel · 2018-08-14T19:20:26Z

docs/edit_first_game_server.md

-3. Follow the install instructions (if you haven't already) at [Install and configure Agones on Kubernetes](../install/README.md). At least, you should have "Setting up a Google Kubernetes Engine (GKE) cluster", "Enabling creation of RBAC resources" and "Installing Agones" done.
+3. Install Agones on GKE or Minikube.  
+
+To install on GKE, follow the install instructions (if you haven't already) at [Install and configure Agones on Kubernetes](../install/README.md). At least, you should have "Setting up a Google Kubernetes Engine (GKE) cluster", "Enabling creation of RBAC resources" and "Installing Agones" done.


We can link to the GKE section directly:
https://github.com/GoogleCloudPlatform/agones/blob/master/install/README.md#setting-up-a-google-kubernetes-engine-gke-cluster

WDYT?

Yes, that would be more consistent.

This change has been made.

markmandel · 2018-08-14T19:21:35Z

docs/edit_first_game_server.md


 ### Create a new docker image
 ```bash
 docker build -t gcr.io/[PROJECT_ID]/agones-udp-server:0.2 .
 ```
 Note that: you can change the image name "agones-udp-server" to something else.

-### Push the image to GCP Registry
+### If using GKE, push the image to GCP Registry
 ```bash
 docker push gcr.io/[PROJECT_ID]/agones-udp-server:0.2


Wondering if we should link to:
https://cloud.google.com/container-registry/docs/advanced-authentication

To point people in the right direction to authenticate against the GCR?

Do you mean add content along the lines of "More information is available at "?

Committed some text adding this link.

Perfect 👍

markmandel · 2018-08-14T19:25:14Z

docs/edit_first_game_server.md

 ```bash
 docker push gcr.io/[PROJECT_ID]/agones-udp-server:0.2
 ```

-### Modify gameserver.yaml
+### If using Minikube, change directory to agones/build and push the image into Minikube
+```bash


Rather than point people to development tools, we can just show them the command line trick:
(just concerned with Agones users relying on development tooling - in case it changes).

docker save [PROJECT_ID]/agones-udp-server:0.2 | (eval $(minikube docker-env) && docker load)

WDYT?

Yes that makes sense. It seems less complex. I tried both ways and eval $(minikube docker-env) etc... worked fine provided the make tools weren't used.

I'm thinking we shouldn't be pointing people towards the development tooling - it's very cross purpose, and developers shouldn't be coupled to our own development tooling.

The doc now uses docker save [PROJECT_ID]/agones-udp-server:0.2 | (eval $(minikube docker-env) && docker load) instead of make.

markmandel · 2018-08-14T19:26:10Z

docs/edit_first_game_server.md

+      containers:
+      - name: agones-simple-udp
+        image: gcr.io/[PROJECT_ID]/agones-udp-server:0.2
+        imagePullPolicy: Never


Do we need imagePullPolicy: Never ? it is the default.

I found I needed it or I would get an error as it failed to pull the image. I'll try without it when not using make.

Hmn. That's weird. Actually, I lie - Never is not the default IfNotPresent - but if you have transferred the image to Minikube, it shouldn't pull it then.

imagePullPolicy: Never has been removed. Now both GKE and Minikube share the same paragraph.

agones-bot · 2018-08-14T20:37:24Z

Build Succeeded 👏

Build Id: e4c15136-db1c-4774-8657-c2c3d830ea60

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.4.0-a8f45a3
image: gcr.io/agones-images/agones-sdk:0.4.0-a8f45a3
Linux C++ SDK (build: dev): agonessdk-0.4.0-a8f45a3-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.4.0-a8f45a3-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.4.0-a8f45a3-src.zip
SDK Server: agonessdk-server-0.4.0-a8f45a3.zip

(experimental) To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/321/head:pr_321 && git checkout pr_321
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.4.0-a8f45a3

agones-bot · 2018-08-14T21:00:08Z

Build Succeeded 👏

Build Id: 30a24203-7cc8-4457-be35-538136e7ad06

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.4.0-c37ec58
image: gcr.io/agones-images/agones-sdk:0.4.0-c37ec58
Linux C++ SDK (build: dev): agonessdk-0.4.0-c37ec58-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.4.0-c37ec58-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.4.0-c37ec58-src.zip
SDK Server: agonessdk-server-0.4.0-c37ec58.zip

(experimental) To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/321/head:pr_321 && git checkout pr_321
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.4.0-c37ec58

agones-bot · 2018-08-16T18:05:10Z

Build Succeeded 👏

Build Id: 287cb09e-30fd-48f6-b317-2e5751b354ae

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.4.0-8291a50
image: gcr.io/agones-images/agones-sdk:0.4.0-8291a50
Linux C++ SDK (build: dev): agonessdk-0.4.0-8291a50-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.4.0-8291a50-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.4.0-8291a50-src.zip
SDK Server: agonessdk-server-0.4.0-8291a50.zip

(experimental) To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/321/head:pr_321 && git checkout pr_321
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.4.0-8291a50

markmandel · 2018-08-18T15:57:24Z

LGTM! Can we rebase down to a single commit, and I'll give it the stamp of approval and merge!

THANKS!

slartibaartfast · 2018-08-18T18:21:24Z

I have some text to cleanup from merging. I left some git stuff in the document that needs to be removed.

agones-bot · 2018-08-18T18:46:55Z

Build Succeeded 👏

Build Id: f6832e79-668e-451d-8354-39a21d106d2f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.4.0-4cf4b2c
image: gcr.io/agones-images/agones-sdk:0.4.0-4cf4b2c
Linux C++ SDK (build: dev): agonessdk-0.4.0-4cf4b2c-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.4.0-4cf4b2c-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.4.0-4cf4b2c-src.zip
SDK Server: agonessdk-server-0.4.0-4cf4b2c.zip

(experimental) To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/321/head:pr_321 && git checkout pr_321
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.4.0-4cf4b2c

slartibaartfast · 2018-08-18T19:00:04Z

It's cleaned up and rebased to a single commit. Next time I will be more careful squashing :)

markmandel reviewed Aug 14, 2018

View reviewed changes

markmandel added kind/documentation Documentation for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Aug 18, 2018

markmandel added this to the 0.4.0 milestone Aug 18, 2018

slartibaartfast force-pushed the master branch from 8291a50 to 29f53bb Compare August 18, 2018 18:13

Add Minikube instructions to edit_first_game_server.md

4cf4b2c

slartibaartfast force-pushed the master branch from 29f53bb to 4cf4b2c Compare August 18, 2018 18:38

markmandel approved these changes Aug 19, 2018

View reviewed changes

markmandel merged commit 32388aa into googleforgames:master Aug 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Minikube instructions #321

Add Minikube instructions #321

slartibaartfast commented Aug 14, 2018

googlebot commented Aug 14, 2018

slartibaartfast commented Aug 14, 2018

googlebot commented Aug 14, 2018

agones-bot commented Aug 14, 2018

agones-bot commented Aug 14, 2018

markmandel left a comment

markmandel Aug 14, 2018

slartibaartfast Aug 14, 2018

markmandel Aug 14, 2018

slartibaartfast Aug 16, 2018

markmandel Aug 14, 2018

slartibaartfast Aug 14, 2018

slartibaartfast Aug 14, 2018

markmandel Aug 14, 2018

slartibaartfast Aug 14, 2018

slartibaartfast Aug 14, 2018

markmandel Aug 14, 2018

markmandel Aug 14, 2018

slartibaartfast Aug 14, 2018

markmandel Aug 14, 2018

slartibaartfast Aug 16, 2018

markmandel Aug 14, 2018

slartibaartfast Aug 14, 2018

markmandel Aug 14, 2018

slartibaartfast Aug 16, 2018

agones-bot commented Aug 14, 2018

agones-bot commented Aug 14, 2018

agones-bot commented Aug 16, 2018

markmandel commented Aug 18, 2018

slartibaartfast commented Aug 18, 2018

agones-bot commented Aug 18, 2018

slartibaartfast commented Aug 18, 2018


		To install on GKE, follow the install instructions (if you haven't already) at [Install and configure Agones on Kubernetes](../install/README.md). At least, you should have "Setting up a Google Kubernetes Engine (GKE) cluster", "Enabling creation of RBAC resources" and "Installing Agones" done.

		To install locally on Minikube, read [Developing, Testing, and Building Agones](../build/README.md) making sure to follow the instructions in the [Running A Test Minikube cluster](../build/README.md#running-a-test-minikube-cluster) section.

Add Minikube instructions #321

Add Minikube instructions #321

Conversation

slartibaartfast commented Aug 14, 2018

googlebot commented Aug 14, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

slartibaartfast commented Aug 14, 2018

googlebot commented Aug 14, 2018

agones-bot commented Aug 14, 2018

agones-bot commented Aug 14, 2018

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Aug 14, 2018

agones-bot commented Aug 14, 2018

agones-bot commented Aug 16, 2018

markmandel commented Aug 18, 2018

slartibaartfast commented Aug 18, 2018

agones-bot commented Aug 18, 2018

slartibaartfast commented Aug 18, 2018