Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label PR #3216

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Label PR #3216

merged 2 commits into from
Jun 14, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind feature

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@markmandel
Copy link
Member

Just checking if this is good to merge yet?

@Kalaiselvi84
Copy link
Contributor Author

Kalaiselvi84 commented Jun 14, 2023

Just checking if this is good to merge yet?

Please don't merge it. It is not working.

The GitHub community suggested that I use the pull_request_target event instead of the pull_request event. I have already tried using the pull_request_target event with write-all permissions - https://github.com/googleforgames/agones/pull/3212/files, but it was not working. I have now added all the required permissions separately. It is also not working🥲

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d81fdec7-6efa-49de-9021-faf5726a42b8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3c5edbde-6eb3-4955-8147-7922b2c7def5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3216/head:pr_3216 && git checkout pr_3216
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-496ca92-amd64

@Kalaiselvi84
Copy link
Contributor Author

@markmandel, Kindly merge this pull request. It should function properly when merged into the main branch that is our default branch.

I've merged the pull request in my fork to test - Kalaiselvi84#280
The script labels a test PR as expected - Kalaiselvi84#281

@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review June 14, 2023 17:10
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 92619a4 into googleforgames:main Jun 14, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Jun 25, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the label branch March 15, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants