-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label PR #3216
Label PR #3216
Conversation
Just checking if this is good to merge yet? |
Please don't merge it. It is not working. The GitHub community suggested that I use the pull_request_target event instead of the pull_request event. I have already tried using the pull_request_target event with write-all permissions - https://github.com/googleforgames/agones/pull/3212/files, but it was not working. I have now added all the required permissions separately. It is also not working🥲 |
Build Failed 😱 Build Id: d81fdec7-6efa-49de-9021-faf5726a42b8 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 3c5edbde-6eb3-4955-8147-7922b2c7def5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@markmandel, Kindly merge this pull request. It should function properly when merged into the main branch that is our default branch. I've merged the pull request in my fork to test - Kalaiselvi84#280 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kalaiselvi84, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: