Delete data-proofer-ignore attribute #3225

Kalaiselvi84 · 2023-06-16T22:59:37Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

Update label-pr.yml

agones-bot · 2023-06-17T00:32:21Z

Build Succeeded 👏

Build Id: 27378424-ac51-478d-baae-ebcebecbb1d9

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-52f17fa-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-52f17fa-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-52f17fa-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-52f17fa-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-52f17fa-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-52f17fa-amd64.zip

A preview of the website (the last 30 builds are retained):

https://52f17fa-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3225/head:pr_3225 && git checkout pr_3225
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-52f17fa-amd64

agones-bot · 2023-06-17T03:04:32Z

Build Succeeded 👏

Build Id: dd8a1e05-e5f4-42bb-a55f-0ed28171c10b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-f1f1768-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-f1f1768-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-f1f1768-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-f1f1768-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-f1f1768-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-f1f1768-amd64.zip

A preview of the website (the last 30 builds are retained):

https://f1f1768-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3225/head:pr_3225 && git checkout pr_3225
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-f1f1768-amd64

agones-bot · 2023-06-20T22:05:55Z

Build Succeeded 👏

Build Id: 8df83520-fc3f-4214-920e-d7750d0dd396

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-c436d77-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-c436d77-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-c436d77-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-c436d77-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-c436d77-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-c436d77-amd64.zip

A preview of the website (the last 30 builds are retained):

https://c436d77-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3225/head:pr_3225 && git checkout pr_3225
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-c436d77-amd64

agones-bot · 2023-06-20T23:28:46Z

Build Succeeded 👏

Build Id: 41c66ecf-faa6-45b4-b34b-a4ff1db6f15c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-d8852e7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-d8852e7-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-d8852e7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-d8852e7-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-d8852e7-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-d8852e7-amd64.zip

A preview of the website (the last 30 builds are retained):

https://d8852e7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3225/head:pr_3225 && git checkout pr_3225
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-d8852e7-amd64

agones-bot · 2023-06-21T01:36:09Z

Build Failed 😱

Build Id: f37f6918-d45a-4a19-a77b-014b6fd17070

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-06-22T21:46:56Z

Ooh same flake one as #3227

--- FAIL: TestAllocatorAllocate (2.63s)
    allocator_test.go:122: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:122
        	Error:      	Expected value not to be nil.
        	Test:       	TestAllocatorAllocate
    allocator_test.go:123: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:123
        	Error:      	Not equal: 
        	            	expected: *errors.fundamental(Could not find an Allocatable GameServer)
        	            	actual  : <nil>(<nil>)
        	Test:       	TestAllocatorAllocate
    allocator_test.go:124: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:124
        	Error:      	Should be false
        	Test:       	TestAllocatorAllocate

markmandel · 2023-06-22T21:48:18Z

docs/governance/templates/release_issue.md

@@ -34,7 +34,7 @@ and copy it into a release issue. Fill in relevant values, found inside {}
  - [ ] Create a new file named {version}.md in `/site/content/en/blog/releases`. Copy the draft release content in this file (this will be what you send via email)[refer the previous release file].
  - run `make site-server` frequently to make sure everything looks fine for the release in your localhost
  - [ ] In `site/content/en/docs/Installation/_index.md #agones-and-kubernetes-supported-versions`, for the current version, replace `{{% k8s-version %}}` with hardcoded Kubernetes versions supported by the current version. And add a row for the Agones release version with `{{% k8s-version %}}` as its supported Kubernetes versions.
-  - [ ] Review all `link_test` and `data-proofer-ignore` attributes and remove for link testing [delete `data-proofer-ignore` from the release file of previous version]
+  - [ ] Run `make del-data-proofer-ignore FILENAME={version}-1.md` to remove `data-proofer-ignore` attribute from previous release blog. Review all occurrences of the link_test and data-proofer-ignore attributes globally. Exclude html and release files.


On FILENAME={version}-1.md - why the -1 ?

In the previous release blog, there will be an occurrence of the 'data-proofer-ignore' attribute that requires removal. If the release version is 1.33.0 then we need to remove this attribute from 1.32.0.md.

Oooooh! Of course, I was readying that as "append -1 to the filename" not "subtract a minor version from {version}".

Thanks!

google-oss-prow · 2023-06-22T23:19:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-06-23T00:06:56Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-06-23T00:56:44Z

Build Failed 😱

Build Id: 1ceadfff-5653-401c-8764-e858216b0217

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-06-23T16:38:20Z

Flake on gke-autopilot-1.25. e2e-stable

RBOSE:     gameserverallocation_test.go:736: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserverallocation_test.go:736
VERBOSE:         	Error:      	Not equal: 
VERBOSE:         	            	expected: 100
VERBOSE:         	            	actual  : 95
VERBOSE:         	Test:       	TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: --- FAIL: TestGameServerAllocationDuringMultipleAllocationClients (66.87s)
VERBOSE: FAIL

agones-bot · 2023-06-24T00:04:44Z

Build Succeeded 👏

Build Id: b241660e-a198-4825-bef8-9a53610d33c2

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-2d25c50-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-2d25c50-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-2d25c50-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-2d25c50-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-2d25c50-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-2d25c50-amd64.zip

A preview of the website (the last 30 builds are retained):

https://2d25c50-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3225/head:pr_3225 && git checkout pr_3225
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-2d25c50-amd64

agones-bot · 2023-06-28T03:17:57Z

Build Succeeded 👏

Build Id: 5aae6f20-9b2a-4b38-83a0-1e8028974fee

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-2d25c50-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-2d25c50-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-2d25c50-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-2d25c50-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-2d25c50-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-2d25c50-amd64.zip

A preview of the website (the last 30 builds are retained):

https://2d25c50-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3225/head:pr_3225 && git checkout pr_3225
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-2d25c50-amd64

Kalaiselvi84 and others added 8 commits June 14, 2023 10:02

Update label-pr.yml

d327edc

Merge pull request #280 from Kalaiselvi84/Kalaiselvi84-patch-62

0780704

Update label-pr.yml

Merge branch 'googleforgames:main' into main

4363005

Merge branch 'googleforgames:main' into main

a20d788

Merge branch 'googleforgames:main' into main

5678289

Merge remote-tracking branch 'upstream/main'

8a5bc91

Merge branch 'googleforgames:main' into main

734209a

Remove data-proofer-ignore attribute

52f17fa

Kalaiselvi84 requested a review from markmandel June 16, 2023 22:59

google-oss-prow bot requested review from cyriltovena and EricFortin June 16, 2023 22:59

google-oss-prow bot added the size/M label Jun 16, 2023

github-actions bot added the kind/feature New features for Agones label Jun 16, 2023

Merge branch 'main' into del-data-proofer-ignore

f1f1768

Kalaiselvi84 added 2 commits June 20, 2023 20:50

changes in passing filename

abb4384

merging

c436d77

small tweak

d8852e7

Merge branch 'main' into del-data-proofer-ignore

93960b6

markmandel reviewed Jun 22, 2023

View reviewed changes

markmandel approved these changes Jun 22, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Jun 22, 2023

google-oss-prow bot added lgtm approved labels Jun 22, 2023

Merge branch 'main' into del-data-proofer-ignore

0a2da17

google-oss-prow bot removed the lgtm label Jun 22, 2023

markmandel approved these changes Jun 22, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Jun 22, 2023

markmandel enabled auto-merge (squash) June 22, 2023 23:34

Merge branch 'main' into del-data-proofer-ignore

b72423b

google-oss-prow bot removed the lgtm label Jun 23, 2023

Merge branch 'main' into del-data-proofer-ignore

2d25c50

markmandel merged commit adf2ebd into googleforgames:main Jun 24, 2023
1 check passed

Kalaiselvi84 deleted the del-data-proofer-ignore branch March 15, 2024 01:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete data-proofer-ignore attribute #3225

Delete data-proofer-ignore attribute #3225

Kalaiselvi84 commented Jun 16, 2023

agones-bot commented Jun 17, 2023

agones-bot commented Jun 17, 2023

agones-bot commented Jun 20, 2023

agones-bot commented Jun 20, 2023

agones-bot commented Jun 21, 2023

markmandel commented Jun 22, 2023

markmandel Jun 22, 2023

Kalaiselvi84 Jun 22, 2023

markmandel Jun 22, 2023

google-oss-prow bot commented Jun 22, 2023

google-oss-prow bot commented Jun 23, 2023

agones-bot commented Jun 23, 2023

markmandel commented Jun 23, 2023

agones-bot commented Jun 24, 2023

agones-bot commented Jun 28, 2023

Delete data-proofer-ignore attribute #3225

Delete data-proofer-ignore attribute #3225

Conversation

Kalaiselvi84 commented Jun 16, 2023

agones-bot commented Jun 17, 2023

agones-bot commented Jun 17, 2023

agones-bot commented Jun 20, 2023

agones-bot commented Jun 20, 2023

agones-bot commented Jun 21, 2023

markmandel commented Jun 22, 2023

markmandel Jun 22, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Jun 22, 2023

Choose a reason for hiding this comment

markmandel Jun 22, 2023

Choose a reason for hiding this comment

google-oss-prow bot commented Jun 22, 2023

google-oss-prow bot commented Jun 23, 2023

agones-bot commented Jun 23, 2023

markmandel commented Jun 23, 2023

agones-bot commented Jun 24, 2023

agones-bot commented Jun 28, 2023