Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for TestAllocatorAllocate* flakiness #3232

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

I can't seem to replicate the flakiness locally, but this is an attempted fix to at least alleviate some issues.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

I can't seem to replicate the flakiness locally, but this is an
attempted fix to at least alleviate some issues.
@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Jun 22, 2023
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 22, 2023
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 22, 2023
@zmerlynn zmerlynn enabled auto-merge (squash) June 22, 2023 22:20
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the lgtm label Jun 22, 2023
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 22, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 74fbc18f-62f4-440c-ae89-cb443e1c2bd4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3232/head:pr_3232 && git checkout pr_3232
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-82d88db-amd64

@zmerlynn zmerlynn merged commit ee00620 into googleforgames:main Jun 23, 2023
@markmandel markmandel deleted the flaky/TestAllocatorAllocate branch June 28, 2023 00:07
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2b31b064-ba60-4850-8e90-75a525b8efa5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3232/head:pr_3232 && git checkout pr_3232
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-82d88db-amd64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants