GKE Autopilot: Add primary container annotation for game server container #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…game server container `autopilot.gke.io/primary-container` is a new annotation that will be supported by Autopilot ~soon that indicates which container resource defaulting should affect. Prior to this if I were to create a GameServer with no resource requests, Autopilot would default-up the sidecar container, as it occurs first. The annotation will be supported in 1.27 ~soon, but this change is safe on all versions (just not useful, necessarily).
zmerlynn
requested review from
markmandel and
gongmax
and removed request for
EricFortin and
roberthbailey
gongmax
reviewed
Jun 26, 2023
|
Build Succeeded 👏 Build Id: 88b96a82-948e-4a6e-980e-58d3cae29d9b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
gongmax
approved these changes
Jun 26, 2023
roberthbailey
approved these changes
Jun 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, roberthbailey, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: 933f0d35-5bc4-4859-b31f-ffe053d4c845 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autopilot.gke.io/primary-containeris a new annotation that will be supported by Autopilot ~soon that indicates which container resource defaulting should affect. Prior to this if I were to create a GameServer with no resource requests, Autopilot would default-up the sidecar container, as it occurs first.The annotation will be supported in 1.27 ~soon, but this change is safe on all versions (just not useful, necessarily).