Graduate CustomFasSyncInterval To Stable #3235

Kalaiselvi84 · 2023-06-26T23:41:56Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3095

Special notes for your reviewer:

markmandel · 2023-06-27T22:38:55Z

Looks like the agones-bot got stuck. If you rebase against main and push force over the top, CI should kick off.

…ones into issues/288583663

Kalaiselvi84 · 2023-06-27T23:31:28Z

I did rebase against main, still agones-bot is not running. Am I missing anything here?

markmandel · 2023-06-27T23:47:29Z

Well that's weird! I'll have to go look!

markmandel · 2023-06-27T23:58:29Z

Ah I see it. One second...

Kalaiselvi84 · 2023-06-28T00:56:24Z

can I try creating a new PR?

markmandel · 2023-06-28T01:03:57Z

Nah, I broke some things, I just fixed them. Running now!

agones-bot · 2023-06-28T01:12:56Z

Build Failed 😱

Build Id: 551afebb-d636-48b0-a07c-2068c7e826dc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-06-29T15:39:44Z

pkg/fleetautoscalers/controller_test.go

 	utilruntime.FeatureTestMutex.Lock()
 	defer utilruntime.FeatureTestMutex.Unlock()


Suggested change

utilruntime.FeatureTestMutex.Lock()

defer utilruntime.FeatureTestMutex.Unlock()

We can remove all of these -- they are only needed when we want to lock down a feature flag within a test.

I have removed it from all the test function in this file.

pkg/fleetautoscalers/controller.go

…ones into issues/288583663

agones-bot · 2023-06-29T17:29:57Z

Build Failed 😱

Build Id: 34e3c100-683f-4eb5-be93-4428f473b5c1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-06-29T22:04:43Z

Oh yeah, sorry - it should run in the container, so it should all just work. Huh, why do I not see it installing Go in the container - that's odd.

markmandel · 2023-06-29T22:09:14Z

Looking at your output, it's missing several steps. Have you changed the .sh file in any way? Running an old version somehow? running on a m2 mac?

This is my output when it runs against main

❯ make gen-api-docs
mkdir -p ~/.kube/
mkdir -p /home/markmandel/workspace/agones/build//.gocache
mkdir -p /home/markmandel/workspace/agones/build//.config/gcloud
mkdir -p ~/.config/helm
mkdir -p ~/.cache/helm
make ensure-image IMAGE_TAG=agones-build:09f8403ba1 BUILD_TARGET=build-build-image
make[1]: Entering directory '/home/markmandel/workspace/agones/build'
make[1]: Leaving directory '/home/markmandel/workspace/agones/build'
docker run -e FILE="/go/src/agones.dev/agones/site/content/en/docs/Reference/agones_crd_api_reference.html" -e VERSION=1.33.0 --rm -i -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build agones-build:09f8403ba1 bash -c "/go/src/agones.dev/agones/site/gen-api-docs.sh"
+ rm -rf /usr/local/go
+ GO_VERSION=1.15.13
+ cd /usr/local
+ wget -q https://dl.google.com/go/go1.15.13.linux-amd64.tar.gz
+ tar -xzf go1.15.13.linux-amd64.tar.gz
+ rm go1.15.13.linux-amd64.tar.gz
+ export GOPROXY=http://proxy.golang.org
+ GOPROXY=http://proxy.golang.org
+ echo 'using go proxy as a workaround for git.agache.org being down: http://proxy.golang.org'
+ cd /go/src/github.com/ahmetb/gen-crd-api-reference-docs
+ go mod edit --replace=agones.dev/agones@latest=../../../agones.dev/agones/
using go proxy as a workaround for git.agache.org being down: http://proxy.golang.org
+ go build
+ cp /go/src/agones.dev/agones/site/assets/templates/pkg.tpl ./template
+ FILE=/go/src/agones.dev/agones/site/content/en/docs/Reference/agones_crd_api_reference.html
+ VERSION=1.33.0
+ TITLE=/tmp/title.html
+ EXPIRY_DOC=/tmp/expiry.html
+ PUBLISH_DOC=/tmp/publish.html
+ RESULT=/tmp/agones_crd_api_reference.html
+ OLD=/tmp/old_docs.html
+ ./gen-crd-api-reference-docs --config ../../../agones.dev/agones/site/assets/templates/crd-doc-config.json --api-dir ../../../agones.dev/agones/pkg/apis/ --out-file /tmp/agones_crd_api_reference.html
I0629 22:07:16.517182     267 main.go:127] parsing go packages in directory ../../../agones.dev/agones/pkg/apis/
W0629 22:07:40.663014     267 parse.go:239] Ignoring child directory agones.dev/agones/pkg/apis/agones/v1/fuzz_test: No files for pkg "agones.dev/agones/pkg/apis/agones/v1/fuzz_test"
I0629 22:07:41.231152     267 main.go:229] using package=agones.dev/agones/pkg/apis/agones/v1
I0629 22:07:41.231163     267 main.go:229] using package=agones.dev/agones/pkg/apis/allocation/v1
I0629 22:07:41.231167     267 main.go:229] using package=agones.dev/agones/pkg/apis/autoscaling/v1
I0629 22:07:41.231169     267 main.go:229] using package=agones.dev/agones/pkg/apis/multicluster/v1
W0629 22:07:41.278711     267 main.go:423] not found external link source for type k8s.io/apimachinery/pkg/util/intstr.IntOrString
W0629 22:07:41.278823     267 main.go:423] not found external link source for type k8s.io/apimachinery/pkg/util/intstr.IntOrString
W0629 22:07:41.278907     267 main.go:423] not found external link source for type k8s.io/apimachinery/pkg/types.UID
W0629 22:07:41.279026     267 main.go:423] not found external link source for type k8s.io/apimachinery/pkg/types.UID
W0629 22:07:41.279941     267 main.go:423] not found external link source for type k8s.io/apimachinery/pkg/util/intstr.IntOrString
W0629 22:07:41.281033     267 main.go:423] not found external link source for type agones.dev/agones/pkg/apis.SchedulingStrategy
W0629 22:07:41.281311     267 main.go:423] not found external link source for type agones.dev/agones/pkg/apis.SchedulingStrategy
W0629 22:07:41.281718     267 main.go:423] not found external link source for type agones.dev/agones/pkg/apis.SchedulingStrategy
W0629 22:07:41.282457     267 main.go:423] not found external link source for type agones.dev/agones/pkg/apis.SchedulingStrategy
W0629 22:07:41.282865     267 main.go:423] not found external link source for type agones.dev/agones/pkg/apis.SchedulingStrategy
W0629 22:07:41.283132     267 main.go:423] not found external link source for type agones.dev/agones/pkg/apis.SchedulingStrategy
W0629 22:07:41.283804     267 main.go:423] not found external link source for type agones.dev/agones/pkg/apis.SchedulingStrategy
W0629 22:07:41.284821     267 main.go:423] not found external link source for type agones.dev/agones/pkg/apis.SchedulingStrategy
W0629 22:07:41.285176     267 main.go:423] not found external link source for type agones.dev/agones/pkg/apis.SchedulingStrategy
I0629 22:07:41.289015     267 main.go:165] written to /tmp/agones_crd_api_reference.html
+ awk '/\ feature\ publishVersion/{flag=1;next}/\ \/feature/{flag=0}flag' /go/src/agones.dev/agones/site/content/en/docs/Reference/agones_crd_api_reference.html
+ awk '/\+\+\+/ {ok=1} /^$/ {ok=0} {if(ok){print $0}}' /go/src/agones.dev/agones/site/content/en/docs/Reference/agones_crd_api_reference.html
+ printf '\n'
++ grep 'feature publishVersion=' /go/src/agones.dev/agones/site/content/en/docs/Reference/agones_crd_api_reference.html
+ doc_version='{{% feature publishVersion="1.33.0" %}}'
+ echo '{{%' feature 'publishVersion="1.33.0"' '%}}'
+ publish='{{% feature publishVersion="1.33.0" %}}'
{{% feature publishVersion="1.33.0" %}}
+ expiry='{{% feature expiryVersion="1.33.0" %}}'
+ sed '/\ expiryVersion="1.33.0"/,/%\ \/feature/!d;/%\ \/feature/q' /go/src/agones.dev/agones/site/content/en/docs/Reference/agones_crd_api_reference.html
+ sed '/\ publishVersion=/,/%\ \/feature/!d;/%\ \/feature/q' /go/src/agones.dev/agones/site/content/en/docs/Reference/agones_crd_api_reference.html
++ sort /tmp/agones_crd_api_reference.html
+ diff /dev/fd/63 /dev/fd/62
++ sort /tmp/old_docs.html

There should be a bunch more commands being run after wget -q https://dl.google.com/go/go1.15.13.linux-amd64.tar.gz

Kalaiselvi84 · 2023-06-29T22:26:00Z

I haven't updated anything in the .sh file. The command fails to work on both my main branch and feature branch.

markmandel · 2023-06-29T22:41:01Z

I just ran the command on a clean machine (no build image, etc), and it all works correctly. So I'm not sure what to suggest 🤔

Kalaiselvi84 · 2023-06-30T01:15:38Z

I just ran the command on a clean machine (no build image, etc), and it all works correctly. So I'm not sure what to suggest 🤔

There was an issue in load metadata for docker.io/library/alpine:3.14. After executing the command sudo systemctl restart docker to restart the Docker service, it appears that the issue related to loading metadata for the alpine:3.14 image and making requests to the Docker registry (registry-1.docker.io) has been resolved. make gen-api-docs command is now working fine.

agones-bot · 2023-06-30T02:06:49Z

Build Succeeded 👏

Build Id: dc4eb2c6-2852-49d1-a0a9-07b5c4f5ab19

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-66fe7b9-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-66fe7b9-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-66fe7b9-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-66fe7b9-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-66fe7b9-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-66fe7b9-amd64.zip

A preview of the website (the last 30 builds are retained):

https://66fe7b9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3235/head:pr_3235 && git checkout pr_3235
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-66fe7b9-amd64

markmandel · 2023-07-06T22:29:56Z

There was an issue in load metadata for docker.io/library/alpine:3.14. After executing the command sudo systemctl restart docker to restart the Docker service, it appears that the issue related to loading metadata for the alpine:3.14 image and making requests to the Docker registry (registry-1.docker.io) has been resolved. make gen-api-docs command is now working fine.

Huh! Weird!

Glad you got it sorted!

markmandel

One small things to fix, otherwise, this looks good to go.

pkg/fleetautoscalers/controller.go

Kalaiselvi84 · 2023-07-06T23:15:18Z

qq, I haven't added feature shortcodes in any of the files. Does everything look good?

markmandel

Good point on the feature shortcodes 👍🏻

site/content/en/docs/Guides/feature-stages.md

markmandel · 2023-07-06T23:25:46Z

site/content/en/docs/Reference/fleetautoscaler.md

@@ -37,8 +37,6 @@ spec:
      # maximum fleet size that can be set by this FleetAutoscaler
      # required
      maxReplicas: 20
-  # [Stage:Beta]


This update should also be feature shortcoded please.

I have a little doubt about this update. Is this correct?

{{% feature expiryVersion="1.34.0" %}} # [Stage:Beta] # [FeatureFlag:CustomFasSyncInterval] {{% /feature %}}

Thaaat might work? But I'm betting it won't.

If you run make site-server you can preview your changes locally and see what works and what doesn't.

Is the behavior shown in the screenshot at https://screenshot.googleplex.com/5nzmXVU6eacV8Kv expected?

There was an issue with make site-server command. This problem has been resolved by adding git config --global --add safe.directory /go/src/agones.dev/agones into the existing code.

Yeah, that doesn't look right (it should be gone), you can also see the preview here: https://1b8d8e1-dot-preview-dot-agones-images.appspot.com/site/docs/reference/fleetautoscaler/

I expect you'll need to feature code the entire block.

I haven't observed any variation in my local environment, whether I utilize feature shortcodes or not. Even if I remove the entire block, I still encounter these lines:

# [Stage:Beta] # [FeatureFlag:CustomFasSyncInterval]

Could you please confirm if it would be harmful if I remove these lines without having the corresponding feature shortcodes?

I think I wasn't clear - much like we do with markdown tables, we would have to duplicate the whole

```yaml .... ...

block.

I tried this too and it was not working in my local 😞 There might be some issue with my local env. committed the changes..

agones-bot · 2023-07-07T01:01:14Z

Build Succeeded 👏

Build Id: 6344132a-c4e0-4ddb-8790-7862c4195bd3

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-1b8d8e1-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-1b8d8e1-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-1b8d8e1-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-1b8d8e1-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-1b8d8e1-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-1b8d8e1-amd64.zip

A preview of the website (the last 30 builds are retained):

https://1b8d8e1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3235/head:pr_3235 && git checkout pr_3235
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-1b8d8e1-amd64

agones-bot · 2023-07-08T01:22:09Z

Build Succeeded 👏

Build Id: 7e368d98-5642-4d0a-99cb-8d45883276a1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-4e45825-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-4e45825-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-4e45825-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-4e45825-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-4e45825-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-4e45825-amd64.zip

A preview of the website (the last 30 builds are retained):

https://4e45825-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3235/head:pr_3235 && git checkout pr_3235
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-4e45825-amd64

agones-bot · 2023-07-08T03:06:40Z

Build Succeeded 👏

Build Id: 90795fd9-a13e-46de-ab37-67da5d2ab50d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-cc537c5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-cc537c5-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-cc537c5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-cc537c5-amd64
Linux C++ SDK (build): agonessdk-1.34.0-dev-cc537c5-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.34.0-dev-cc537c5-amd64.zip

A preview of the website (the last 30 builds are retained):

https://cc537c5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3235/head:pr_3235 && git checkout pr_3235
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-cc537c5-amd64

markmandel · 2023-07-10T22:33:03Z

https://cc537c5-dot-preview-dot-agones-images.appspot.com/site/docs/reference/fleetautoscaler/ looks good!

google-oss-prow · 2023-07-10T22:33:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Kalaiselvi84 added 2 commits June 26, 2023 23:25

Graduate CustomFasSyncInterval to Stable

2fca1f4

Merge main branch into issues/288583663

f96dd93

Kalaiselvi84 requested a review from markmandel June 26, 2023 23:41

google-oss-prow bot requested review from EricFortin and roberthbailey June 26, 2023 23:42

google-oss-prow bot added the size/L label Jun 26, 2023

github-actions bot added the kind/feature New features for Agones label Jun 26, 2023

Kalaiselvi84 marked this pull request as draft June 27, 2023 00:18

google-oss-prow bot added the do-not-merge/work-in-progress label Jun 27, 2023

Kalaiselvi84 added 2 commits June 27, 2023 23:23

Rebase

e79bfc0

Merge branch 'issues/288583663' of https://github.com/Kalaiselvi84/ag…

f2c1304

…ones into issues/288583663

markmandel force-pushed the issues/288583663 branch from f2c1304 to 994842c Compare June 28, 2023 00:20

Graduate CustomFasSyncInterval to Stable

8880b0c

markmandel force-pushed the issues/288583663 branch from 994842c to 8880b0c Compare June 28, 2023 00:48

markmandel reviewed Jun 29, 2023

View reviewed changes

Kalaiselvi84 added 2 commits June 29, 2023 17:03

Merge branch 'issues/288583663' of https://github.com/Kalaiselvi84/ag…

9d8cea6

…ones into issues/288583663

suggested modification in controller file

7135754

Kalaiselvi84 marked this pull request as ready for review June 29, 2023 17:29

google-oss-prow bot removed the do-not-merge/work-in-progress label Jun 29, 2023

google-oss-prow bot requested a review from markmandel June 29, 2023 17:29

Kalaiselvi84 marked this pull request as draft June 29, 2023 17:30

google-oss-prow bot added the do-not-merge/work-in-progress label Jun 29, 2023

Kalaiselvi84 added 2 commits June 30, 2023 01:06

make gen-api-docs updated the agones_crd_api_reference.html

292d40f

Merge branch 'main' into issues/288583663

66fe7b9

Kalaiselvi84 marked this pull request as ready for review June 30, 2023 03:49

google-oss-prow bot removed the do-not-merge/work-in-progress label Jun 30, 2023

google-oss-prow bot requested a review from aLekSer June 30, 2023 03:49

markmandel reviewed Jul 6, 2023

View reviewed changes

pkg/fleetautoscalers/controller.go Show resolved Hide resolved

modified controller.go

f38d5cb

markmandel reviewed Jul 6, 2023

View reviewed changes

added feature shortcodes

1b8d8e1

updated fleetautoscaler.md

4e45825

Merge branch 'main' into issues/288583663

cc537c5

markmandel approved these changes Jul 10, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Jul 10, 2023

google-oss-prow bot added the lgtm label Jul 10, 2023

markmandel merged commit 635573e into googleforgames:main Jul 10, 2023

google-oss-prow bot added the approved label Jul 10, 2023

Kalaiselvi84 deleted the issues/288583663 branch March 15, 2024 01:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graduate CustomFasSyncInterval To Stable #3235

Graduate CustomFasSyncInterval To Stable #3235

Kalaiselvi84 commented Jun 26, 2023

markmandel commented Jun 27, 2023

Kalaiselvi84 commented Jun 27, 2023

markmandel commented Jun 27, 2023

markmandel commented Jun 27, 2023

Kalaiselvi84 commented Jun 28, 2023

markmandel commented Jun 28, 2023

agones-bot commented Jun 28, 2023

markmandel Jun 29, 2023

Kalaiselvi84 Jun 29, 2023

agones-bot commented Jun 29, 2023

markmandel commented Jun 29, 2023

markmandel commented Jun 29, 2023

Kalaiselvi84 commented Jun 29, 2023

markmandel commented Jun 29, 2023

Kalaiselvi84 commented Jun 30, 2023 •

edited

Loading

agones-bot commented Jun 30, 2023

markmandel commented Jul 6, 2023

markmandel left a comment

Kalaiselvi84 commented Jul 6, 2023

markmandel left a comment

markmandel Jul 6, 2023

Kalaiselvi84 Jul 7, 2023 •

edited

Loading

markmandel Jul 7, 2023

Kalaiselvi84 Jul 7, 2023 •

edited

Loading

markmandel Jul 7, 2023

Kalaiselvi84 Jul 7, 2023 •

edited

Loading

markmandel Jul 7, 2023

Kalaiselvi84 Jul 8, 2023

agones-bot commented Jul 7, 2023

agones-bot commented Jul 8, 2023

agones-bot commented Jul 8, 2023

markmandel commented Jul 10, 2023

google-oss-prow bot commented Jul 10, 2023

		utilruntime.FeatureTestMutex.Lock()
		defer utilruntime.FeatureTestMutex.Unlock()

Graduate CustomFasSyncInterval To Stable #3235

Graduate CustomFasSyncInterval To Stable #3235

Conversation

Kalaiselvi84 commented Jun 26, 2023

markmandel commented Jun 27, 2023

Kalaiselvi84 commented Jun 27, 2023

markmandel commented Jun 27, 2023

markmandel commented Jun 27, 2023

Kalaiselvi84 commented Jun 28, 2023

markmandel commented Jun 28, 2023

agones-bot commented Jun 28, 2023

markmandel Jun 29, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Jun 29, 2023

Choose a reason for hiding this comment

agones-bot commented Jun 29, 2023

markmandel commented Jun 29, 2023

markmandel commented Jun 29, 2023

Kalaiselvi84 commented Jun 29, 2023

markmandel commented Jun 29, 2023

Kalaiselvi84 commented Jun 30, 2023 • edited Loading

agones-bot commented Jun 30, 2023

markmandel commented Jul 6, 2023

markmandel left a comment

Choose a reason for hiding this comment

Kalaiselvi84 commented Jul 6, 2023

markmandel left a comment

Choose a reason for hiding this comment

markmandel Jul 6, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Jul 7, 2023 • edited Loading

Choose a reason for hiding this comment

markmandel Jul 7, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Jul 7, 2023 • edited Loading

Choose a reason for hiding this comment

markmandel Jul 7, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Jul 7, 2023 • edited Loading

Choose a reason for hiding this comment

markmandel Jul 7, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Jul 8, 2023

Choose a reason for hiding this comment

agones-bot commented Jul 7, 2023

agones-bot commented Jul 8, 2023

agones-bot commented Jul 8, 2023

markmandel commented Jul 10, 2023

google-oss-prow bot commented Jul 10, 2023

Kalaiselvi84 commented Jun 30, 2023 •

edited

Loading

Kalaiselvi84 Jul 7, 2023 •

edited

Loading

Kalaiselvi84 Jul 7, 2023 •

edited

Loading

Kalaiselvi84 Jul 7, 2023 •

edited

Loading