fix: Enabling SplitControllerAndExtensions leads to incomplete metrics availability #3242

aimuz · 2023-07-03T06:54:01Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind bug

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3244
Closes #3190

Special notes for your reviewer:

The PR fix is to create a new service dedicated to providing metrics, as the extensions metrics are very limited and a lot of metrics are still in the controller.

agones-bot · 2023-07-03T07:07:14Z

Build Failed 😱

Build Id: b327d384-bcce-4936-8f7c-155296a162c5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aimuz · 2023-07-03T08:57:28Z

install/yaml/install.yaml

@@ -16435,39 +16501,39 @@ spec:
          readOnly: true
 ---
 # Source: agones/templates/extensions.yaml
-apiVersion: apiregistration.k8s.io/v1


Strange diff changes, they are exactly the same

aimuz · 2023-07-03T08:57:44Z

install/yaml/install.yaml

  version: v1
 ---
 # Source: agones/templates/extensions.yaml
-# Copyright 2018 Google LLC All Rights Reserved.


Strange diff changes, they are exactly the same

agones-bot · 2023-07-03T09:02:02Z

Build Failed 😱

Build Id: 736a67a3-4e21-42f6-934d-fe3bf02f5b27

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-07-03T10:00:43Z

Build Succeeded 👏

Build Id: fa0fc23f-a1bc-40ff-8b49-e8f63bbae23b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-dev-4fdd060-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-dev-4fdd060-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-dev-4fdd060-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-dev-4fdd060-amd64
Linux C++ SDK (build): agonessdk-1.33.0-dev-4fdd060-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-dev-4fdd060-amd64.zip

A preview of the website (the last 30 builds are retained):

https://4fdd060-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3242/head:pr_3242 && git checkout pr_3242
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-4fdd060-amd64

aimuz · 2023-07-06T01:39:22Z

@markmandel Can you take a look at this?

aimuz · 2023-07-06T01:45:32Z

ref: #3190

markmandel · 2023-07-06T16:37:55Z

Calling @chiayi - you were looking into this stuff, yeah?

markmandel · 2023-07-06T22:48:23Z

In which case, I defer review to you @chiayi 😄

aimuz · 2023-07-07T10:30:46Z

In our environment, this works fine and we can see the relevant metrics

chiayi · 2023-07-07T17:49:05Z

Sorry for the delay, I was able to run it as well and it works fine LGTM

agones-bot · 2023-07-07T18:04:07Z

Build Failed 😱

Build Id: ce0d439a-278f-4362-b22b-2b23ec439af4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-07-07T18:10:22Z

You'll need to run make gen-install please and update. Since the install.yaml changed because of the Helm changes.

… some metrics not being available Signed-off-by: aimuz <mr.imuz@gmail.com>

aimuz · 2023-07-08T02:38:16Z

You'll need to run make gen-install please and update. Since the install.yaml changed because of the Helm changes.

thank you, I'm done

agones-bot · 2023-07-08T03:50:08Z

Build Succeeded 👏

Build Id: 315e1249-f776-49ec-9a55-1b10a111085d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-a3a7206-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-a3a7206-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-a3a7206-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-a3a7206-amd64
Linux C++ SDK (build): agonessdk-1.34.0-dev-a3a7206-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.34.0-dev-a3a7206-amd64.zip

A preview of the website (the last 30 builds are retained):

https://a3a7206-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3242/head:pr_3242 && git checkout pr_3242
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-a3a7206-amd64

aimuz · 2023-07-10T22:57:48Z

/assign @markmandel

markmandel · 2023-07-10T23:13:57Z

@chiayi just triple checking before I approve and merge - this looks good to go on your end?

markmandel · 2023-07-10T23:17:26Z

Ignore me - you already approved 👍🏻

google-oss-prow · 2023-07-10T23:17:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, chiayi, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

aimuz · 2023-07-11T01:54:28Z

Is there anything else this PR needs to do to merge?

google-oss-prow · 2023-07-11T06:44:50Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-07-11T07:51:26Z

Build Succeeded 👏

Build Id: e4ff8230-678e-438e-8f15-90616dbcd51a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-68f0195-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-68f0195-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-68f0195-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-68f0195-amd64
Linux C++ SDK (build): agonessdk-1.34.0-dev-68f0195-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.34.0-dev-68f0195-amd64.zip

A preview of the website (the last 30 builds are retained):

https://68f0195-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3242/head:pr_3242 && git checkout pr_3242
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-68f0195-amd64

google-oss-prow bot added the size/M label Jul 3, 2023

github-actions bot added the kind/bug These are bugs. label Jul 3, 2023

aimuz force-pushed the fix-metrics branch from eb86a32 to 8288d4d Compare July 3, 2023 06:54

google-oss-prow bot requested review from cyriltovena and markmandel July 3, 2023 06:54

aimuz force-pushed the fix-metrics branch 2 times, most recently from 9a55b4e to 1d3325f Compare July 3, 2023 06:55

aimuz force-pushed the fix-metrics branch from 1d3325f to 05cab02 Compare July 3, 2023 08:46

google-oss-prow bot added size/L and removed size/M labels Jul 3, 2023

aimuz force-pushed the fix-metrics branch from 05cab02 to ee14021 Compare July 3, 2023 08:50

aimuz commented Jul 3, 2023

View reviewed changes

aimuz changed the title ~~fix: SplitControllerAndExtensions turned on by default will result in some metrics not being available~~ fix: Enabling SplitControllerAndExtensions leads to incomplete metrics availability Jul 3, 2023

aimuz mentioned this pull request Jul 4, 2023

Bug in the ServiceMap config of the SplitControllerAndExtensions feature #3244

Closed

chiayi mentioned this pull request Jul 5, 2023

fix: Unable to collect controller metrics when SplitControllerAndExte… #3243

Closed

markmandel requested a review from chiayi July 6, 2023 22:46

chiayi approved these changes Jul 7, 2023

View reviewed changes

google-oss-prow bot assigned chiayi Jul 7, 2023

google-oss-prow bot added the lgtm label Jul 7, 2023

markmandel enabled auto-merge (squash) July 7, 2023 17:52

google-oss-prow bot removed the lgtm label Jul 7, 2023

fix: SplitControllerAndExtensions turned on by default will result in…

a3a7206

… some metrics not being available Signed-off-by: aimuz <mr.imuz@gmail.com>

auto-merge was automatically disabled July 8, 2023 02:35
Head branch was pushed to by a user without write access

aimuz force-pushed the fix-metrics branch from 00b92d0 to a3a7206 Compare July 8, 2023 02:35

aimuz requested a review from chiayi July 8, 2023 02:38

chiayi approved these changes Jul 10, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Jul 10, 2023

google-oss-prow bot assigned markmandel Jul 10, 2023

markmandel approved these changes Jul 10, 2023

View reviewed changes

markmandel enabled auto-merge (squash) July 10, 2023 23:17

google-oss-prow bot added the approved label Jul 10, 2023

Merge branch 'main' into fix-metrics

68f0195

google-oss-prow bot removed the lgtm label Jul 11, 2023

markmandel merged commit c431327 into googleforgames:main Jul 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Enabling SplitControllerAndExtensions leads to incomplete metrics availability #3242

fix: Enabling SplitControllerAndExtensions leads to incomplete metrics availability #3242

aimuz commented Jul 3, 2023 •

edited

Loading

agones-bot commented Jul 3, 2023

aimuz Jul 3, 2023

aimuz Jul 3, 2023

agones-bot commented Jul 3, 2023

agones-bot commented Jul 3, 2023

aimuz commented Jul 6, 2023

aimuz commented Jul 6, 2023

markmandel commented Jul 6, 2023

markmandel commented Jul 6, 2023

aimuz commented Jul 7, 2023

chiayi commented Jul 7, 2023

agones-bot commented Jul 7, 2023

markmandel commented Jul 7, 2023

aimuz commented Jul 8, 2023

agones-bot commented Jul 8, 2023

aimuz commented Jul 10, 2023

markmandel commented Jul 10, 2023

markmandel commented Jul 10, 2023

google-oss-prow bot commented Jul 10, 2023

aimuz commented Jul 11, 2023

google-oss-prow bot commented Jul 11, 2023

agones-bot commented Jul 11, 2023

fix: Enabling SplitControllerAndExtensions leads to incomplete metrics availability #3242

fix: Enabling SplitControllerAndExtensions leads to incomplete metrics availability #3242

Conversation

aimuz commented Jul 3, 2023 • edited Loading

agones-bot commented Jul 3, 2023

aimuz Jul 3, 2023

Choose a reason for hiding this comment

aimuz Jul 3, 2023

Choose a reason for hiding this comment

agones-bot commented Jul 3, 2023

agones-bot commented Jul 3, 2023

aimuz commented Jul 6, 2023

aimuz commented Jul 6, 2023

markmandel commented Jul 6, 2023

markmandel commented Jul 6, 2023

aimuz commented Jul 7, 2023

chiayi commented Jul 7, 2023

agones-bot commented Jul 7, 2023

markmandel commented Jul 7, 2023

aimuz commented Jul 8, 2023

agones-bot commented Jul 8, 2023

aimuz commented Jul 10, 2023

markmandel commented Jul 10, 2023

markmandel commented Jul 10, 2023

google-oss-prow bot commented Jul 10, 2023

aimuz commented Jul 11, 2023

google-oss-prow bot commented Jul 11, 2023

agones-bot commented Jul 11, 2023

aimuz commented Jul 3, 2023 •

edited

Loading