Preparation for 1.34.0 #3248
Preparation for 1.34.0 #3248
Conversation
|
Build Succeeded 👏 Build Id: 7ad54215-b9b8-4c9b-9126-c4f8d5b5449f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| - [ ] Run `make release-branch` to create a release branch. | ||
| - [ ] Email the [mailing list][list] with the release details (copy-paste the release blog post). | ||
| - [ ] Run `make release-branch` to create a release branch and run `gcloud config configurations activate <your development project>` to switch Agones development tooling off of the `agones-images` project. | ||
| - [ ] Email the `mailing list` with the release details (copy-paste the release blog post). `Internal Agones Release Guide` has the mailing list. |
There was a problem hiding this comment.
nit: Not sure whether it matters but Internal Agones Release Guide here is not very clear to those who don't know about the doc. Maybe explicitly call out the mailing lists here.
There was a problem hiding this comment.
If my understanding is correct, we should refrain from sharing the internal document in a public forum. @markmandel, please correct me if I'm mistaken.
There was a problem hiding this comment.
We can link to the public google group - that's fine. Maybe something like the following:
| - [ ] Email the `mailing list` with the release details (copy-paste the release blog post). `Internal Agones Release Guide` has the mailing list. | |
| - [ ] Email all mailing lists with the release details (copy-paste the release blog post). | |
| - [ ] Public (agones discuss)[list] mailing list | |
| - [ ] Googlers: Check the [Internal Release Guide](go/agones-release-guide) for extra steps at this stage. |
We use go links in a few projects to link to internal stuff - but also being deliberately vague 😄
There was a problem hiding this comment.
I have included both the public email list and the Googlers email list in the [Internal] Agones Release Guide and added the corresponding link(go/agones-release-guide). Does it look good?
| - [ ] Run `make release-branch` to create a release branch. | ||
| - [ ] Email the [mailing list][list] with the release details (copy-paste the release blog post). | ||
| - [ ] Run `make release-branch` to create a release branch and run `gcloud config configurations activate <your development project>` to switch Agones development tooling off of the `agones-images` project. | ||
| - [ ] Email the `mailing list` with the release details (copy-paste the release blog post). Refer [Internal Mailing list posting](go/agones-release-guide). |
There was a problem hiding this comment.
Minor nits on grammar:
| - [ ] Email the `mailing list` with the release details (copy-paste the release blog post). Refer [Internal Mailing list posting](go/agones-release-guide). | |
| - [ ] Email mailing lists with the release details (copy-paste the release blog post). Refer to the [Internal Mailing list posting guide](go/agones-release-guide) for details. |
Other than that, LGTM.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kalaiselvi84, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: c3405754-25fb-42cd-91b5-e66d2b7cb1a0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind release
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3246
Special notes for your reviewer: