Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put e2e Cloud Build logs in public bucket #3250

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

The e2e test logs are not accessible to non googlers right now, as they don't get streamed to the gs://agones-build-logs bucket, and this fixes that.

Which issue(s) this PR fixes:

Reported in #3239

Special notes for your reviewer:

N/A

The e2e test logs are not accessible to non googlers right now, as they
don't get streamed to the `gs://agones-build-logs` bucket, and this
fixes that.
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Jul 7, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 22767567-4822-4b16-9fbd-94dd98a70130

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3250/head:pr_3250 && git checkout pr_3250
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-0078abf-amd64

@gongmax gongmax merged commit 88c38fa into googleforgames:main Jul 7, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel deleted the e2e/public-log-bucket branch July 12, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants