Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Checklist Cleanup #3258

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Conversation

Kalaiselvi84
Copy link
Contributor

@Kalaiselvi84 Kalaiselvi84 commented Jul 12, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2454

Special notes for your reviewer:

@github-actions github-actions bot added the kind/documentation Documentation for Agones label Jul 12, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: cbfb2c5f-474e-4931-8e0d-d2361da4ba1c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Jul 13, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@markmandel
Copy link
Member

Unit test flake:

--- FAIL: TestControllerAllocator (3.68s)
    --- FAIL: TestControllerAllocator/successful_allocation (3.67s)
        controller_test.go:118: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:118
            	            				/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:125
            	Error:      	Should be true
            	Test:       	TestControllerAllocator/successful_allocation
            	Messages:   	Failed: UnAllocated vs Allocated
        controller_test.go:118: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:118
            	            				/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:126
            	Error:      	Should be true
            	Test:       	TestControllerAllocator/successful_allocation
            	Messages:   	Failed: UnAllocated vs Allocated

@markmandel markmandel enabled auto-merge (squash) July 13, 2023 20:48
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 27602bb5-26d2-42e4-b71f-fe107a4e03f5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3258/head:pr_3258 && git checkout pr_3258
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-6833f56-amd64

@markmandel markmandel merged commit 15e43ed into googleforgames:main Jul 13, 2023
1 check passed
@Kalaiselvi84 Kalaiselvi84 deleted the pr_2454 branch March 15, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Automation: Create a script to set versions on the calendar
3 participants