-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Status > Address & Ports population to Creating
state processing
#326
Move Status > Address & Ports population to Creating
state processing
#326
Conversation
Previously the IP and Ports of the GameServer were populated only when the GameServer is set to Ready. This information may be needed by the GameServer process before the process actually wants to mark itself as Ready. Therefore, port and address population has been moved to the `Creating` state processing, as that is where the Pod is created, and therefore we have both address and port information. `GameServer` events now look like this: ``` Events: Type Reason Age From Message ---- ------ ---- ---- ------- Normal PortAllocation 17s gameserver-controller Port allocated Normal Creating 16s gameserver-controller Pod simple-udp-fcf44 created Normal Starting 16s gameserver-controller Address and Port populated Normal Ready 15s gameserver-controller SDK.Ready() executed ``` Closes googleforgames#293
Build Succeeded 👏 Build Id: 9f70cce2-9f3f-47c9-9a29-1d6da652b546 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Looks ok to me but I'm no go guru, to put it mildly.... But this feature îs definitely helpful, am glad to see it. |
I spent about 30 minutes looking this morning and couldn't see anything obviously wrong but very new to this. Will also see if I can check out a couple of PRs over the weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this looks good !
Build Succeeded 👏 Build Id: 061478e9-63f3-4a43-a10c-b80127d92a49 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Previously the IP and Ports of the
GameServer
were populated only when theGameServer
is set to Ready.This information may be needed by the
GameServer
process before the process actually wants to mark itself as Ready.Therefore, port and address population has been moved to the
Creating
state processing, as that is where the Pod is created, and therefore we have both address and port information.GameServer
events now look like this:Closes #293