Race Flake in TestControllerSyncFleetAutoscaler() #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weird that this has more consistently failed with the Go race condition checker failing on this test recently -- but it's a test we wrote a while ago! The flake was that the test added a Reactor to the mock _after_ the Informer system had been started - which caused a race condition inside the Fake client system as different systems interacted with the mock. Changing the order fixes the issue!
markmandel
added
kind/bug
zmerlynn
approved these changes
Jul 12, 2023
igooch
approved these changes
Jul 12, 2023
gongmax
approved these changes
Jul 12, 2023
roberthbailey
approved these changes
Jul 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, igooch, markmandel, roberthbailey, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: e1e4cebd-abeb-4f73-b565-526cd7c9933d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Weird that this has more consistently failed with the Go race condition checker failing on this test recently -- but it's a test we wrote a while ago!
The flake was that the test added a Reactor to the mock after the Informer system had been started - which caused a race condition inside the Fake client system as different systems interacted with the mock.
Changing the order fixes the issue!
Which issue(s) this PR fixes:
Helps #3211 move forward.
Special notes for your reviewer:
N/A