Alpine ➡️ Distroless as Agones base image #3270
Conversation
markmandel
added
kind/feature
|
Build Failed 😱 Build Id: 464fef3d-a6b3-44bf-bd92-3d0b51c5d592 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
|
||
| USER 1000 | ||
| ENTRYPOINT ["/home/agones/allocator"] | ||
| USER nonroot:nonroot |
There was a problem hiding this comment.
A dump question, is this needed if the nonroot image is used?
There was a problem hiding this comment.
You know, I always assumed so, but the distroless docs are... not the best 😄 so it's a good question to ask.
We can try and see.
Alpine 3.14 stopped getting security updates back in May of this year, so we needed to update things anyway. Seemed like a good time to move over to the Google supported base container image. Also since we're always building off distroless' latest image, we don't need to update version numbers to make sure releases always have the latest version, so we always get ongoing security updates. Work on googleforgames#909
markmandel
force-pushed
the
security/distroless
branch
from
571552b
to
8381d7f
Compare
|
Build Succeeded 👏 Build Id: 28879d17-7b30-40ce-9fc4-83be61927f68 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aimuz, gongmax, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: b99b2c0c-bb8f-4668-95a5-b55af95d6577 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Alpine 3.14 stopped getting security updates back in May of this year, so we needed to update things anyway. Seemed like a good time to move over to the Google supported base container image.
Also since we're always building off distroless' latest image, we don't need to update version numbers to make sure releases always have the latest version, so we always get ongoing security updates.
Which issue(s) this PR fixes:
Work on #909
Special notes for your reviewer:
Next step to close out #909 would be to update the examples as well (particularly simple-game-server).