Switching autoscaler-webhook to utilize distroless as base Image #3276

Kalaiselvi84 · 2023-07-19T20:45:04Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #909

Special notes for your reviewer:

agones-bot · 2023-07-19T21:02:28Z

Build Failed 😱

Build Id: d32fd147-4bce-4f9b-a203-338fe643b306

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Good start!

Can you also have a look through our docs to see what references the autoscaler-webhook container image, and update that as well?

We'll also need to manually test to make sure it still works please.

markmandel · 2023-07-19T21:05:59Z

examples/autoscaler-webhook/Dockerfile

@@ -22,7 +22,7 @@ RUN go mod init && go mod tidy
 RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -o server .

 # Create the final image that will run the webhook server for FleetAutoscaler webhook policy
-FROM alpine:3.14
+FROM gcr.io/distroless/static-debian11:nonroot
 RUN adduser -D -u 1000 server


Suggested change

RUN adduser -D -u 1000 server

WORKDIR /

No need for this anymore, and we move everything into root.

markmandel · 2023-07-19T21:07:18Z

examples/autoscaler-webhook/Dockerfile

@@ -22,7 +22,7 @@ RUN go mod init && go mod tidy
 RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -o server .

 # Create the final image that will run the webhook server for FleetAutoscaler webhook policy
-FROM alpine:3.14
+FROM gcr.io/distroless/static-debian11:nonroot
 RUN adduser -D -u 1000 server

 COPY --from=builder /go/src/autoscaler-webhook \


change this to copy to /server

markmandel · 2023-07-19T21:07:26Z

examples/autoscaler-webhook/Dockerfile

@@ -31,5 +31,5 @@ COPY --from=builder /go/src/autoscaler-webhook \
 RUN chown -R server /home/server && \


This can all go away.

markmandel · 2023-07-19T21:07:42Z

examples/autoscaler-webhook/Dockerfile

-USER 1000
-ENTRYPOINT /home/server/server
+USER nonroot:nonroot
+ENTRYPOINT ["/home/server/server"]


Suggested change

ENTRYPOINT ["/home/server/server"]

ENTRYPOINT ["/server"]

Kalaiselvi84 · 2023-07-19T23:14:59Z

Can you also have a look through our docs to see what references the autoscaler-webhook container image, and update that as well?

Do we have a need to update all files , excluding release blogs, that currently using "autoscaler-webhook 0.6" to instead use "autoscaler-webhook 0.7"?

markmandel · 2023-07-19T23:24:36Z

Do we have a need to update all files , excluding release blogs, that currently using "autoscaler-webhook 0.6" to instead use "autoscaler-webhook 0.7"?

Yes please!

Kalaiselvi84 · 2023-07-19T23:39:26Z

We'll also need to manually test to make sure it still works please.

could you please provide more context?

agones-bot · 2023-07-20T00:21:48Z

Build Failed 😱

Build Id: 7ed1de35-e84f-4e51-96ef-85a1b8ef131d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-07-20T19:20:28Z

could you please provide more context?

Ah yes - excellent question!

We use this image in this quickstart: https://agones.dev/site/docs/getting-started/create-webhook-fleetautoscaler/

So if you can go through this quickstart, but utilise your new image rather than the old one, that would be perfect.

markmandel

Chatted with @Kalaiselvi84 offline. Tested, and looks good 👍🏻

google-oss-prow · 2023-07-21T18:48:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-07-21T18:59:51Z

Build Failed 😱

Build Id: ebe73d41-4e88-494d-a83f-fd5b300573a4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-07-21T19:12:02Z

--- FAIL: TestAllocatorAllocateOnGameServerUpdateError (19.31s)
    allocator_test.go:499: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:499
        	Error:      	An error is expected but got nil.
        	Test:       	TestAllocatorAllocateOnGameServerUpdateError

flake. I thought I fixed this.

agones-bot · 2023-07-21T20:01:24Z

Build Failed 😱

Build Id: 3396222b-a8c2-4c9e-81a0-f16d73ac52b8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-07-21T20:05:34Z

@Kalaiselvi84 is the image pushed yet? If not, that would explain why the e2e tests are failing 😄

Kalaiselvi84 · 2023-07-21T20:33:45Z

@Kalaiselvi84 is the image pushed yet? If not, that would explain why the e2e tests are failing 😄

I used go mod init to create the go.mod and go.sum files, but unfortunately, the issue persists when attempting to run the make push command.

…ones into issues/291828200

google-oss-prow · 2023-07-21T21:58:27Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-07-21T22:10:23Z

Build Failed 😱

Build Id: e6b7406c-c6f6-4419-8f85-248dd2681349

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-07-22T02:25:29Z

Build Succeeded 👏

Build Id: 957feef5-77f9-4582-b789-3667f8b06245

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://59bffb6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3276/head:pr_3276 && git checkout pr_3276
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-59bffb6-amd64

Migrating autoscaler-webhook to utilize Distroless as Base Image

99b4ab9

Kalaiselvi84 requested a review from markmandel July 19, 2023 20:45

google-oss-prow bot requested review from aLekSer and EricFortin July 19, 2023 20:45

google-oss-prow bot added the size/XS label Jul 19, 2023

github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Jul 19, 2023

markmandel reviewed Jul 19, 2023

View reviewed changes

Necessary changes

38decd8

google-oss-prow bot added size/S and removed size/XS labels Jul 19, 2023

autoscaler-webhook tag increased

9d4d6ab

Merge branch 'main' into issues/291828200

e106a55

markmandel approved these changes Jul 21, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Jul 21, 2023

google-oss-prow bot added the lgtm label Jul 21, 2023

google-oss-prow bot added the approved label Jul 21, 2023

markmandel enabled auto-merge (squash) July 21, 2023 18:53

Created go.mod and go.sum for autoscler-webhook

d2435f3

Merge branch 'issues/291828200' of https://github.com/Kalaiselvi84/ag…

781fb26

…ones into issues/291828200

google-oss-prow bot removed the lgtm label Jul 21, 2023

google-oss-prow bot added size/L and removed size/S labels Jul 21, 2023

Merge branch 'main' into issues/291828200

59bffb6

markmandel merged commit 8f575ed into googleforgames:main Jul 22, 2023
2 checks passed

Kalaiselvi84 deleted the issues/291828200 branch March 15, 2024 01:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switching autoscaler-webhook to utilize distroless as base Image #3276

Switching autoscaler-webhook to utilize distroless as base Image #3276

Kalaiselvi84 commented Jul 19, 2023

agones-bot commented Jul 19, 2023

markmandel left a comment

markmandel Jul 19, 2023

markmandel Jul 19, 2023

markmandel Jul 19, 2023

markmandel Jul 19, 2023

Kalaiselvi84 commented Jul 19, 2023 •

edited

Loading

markmandel commented Jul 19, 2023

Kalaiselvi84 commented Jul 19, 2023

agones-bot commented Jul 20, 2023

markmandel commented Jul 20, 2023

markmandel left a comment

google-oss-prow bot commented Jul 21, 2023

agones-bot commented Jul 21, 2023

markmandel commented Jul 21, 2023

agones-bot commented Jul 21, 2023

markmandel commented Jul 21, 2023

Kalaiselvi84 commented Jul 21, 2023

google-oss-prow bot commented Jul 21, 2023

agones-bot commented Jul 21, 2023

agones-bot commented Jul 22, 2023

		@@ -31,5 +31,5 @@ COPY --from=builder /go/src/autoscaler-webhook \
		RUN chown -R server /home/server && \

Switching autoscaler-webhook to utilize distroless as base Image #3276

Switching autoscaler-webhook to utilize distroless as base Image #3276

Conversation

Kalaiselvi84 commented Jul 19, 2023

agones-bot commented Jul 19, 2023

markmandel left a comment

Choose a reason for hiding this comment

markmandel Jul 19, 2023

Choose a reason for hiding this comment

markmandel Jul 19, 2023

Choose a reason for hiding this comment

markmandel Jul 19, 2023

Choose a reason for hiding this comment

markmandel Jul 19, 2023

Choose a reason for hiding this comment

Kalaiselvi84 commented Jul 19, 2023 • edited Loading

markmandel commented Jul 19, 2023

Kalaiselvi84 commented Jul 19, 2023

agones-bot commented Jul 20, 2023

markmandel commented Jul 20, 2023

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Jul 21, 2023

agones-bot commented Jul 21, 2023

markmandel commented Jul 21, 2023

agones-bot commented Jul 21, 2023

markmandel commented Jul 21, 2023

Kalaiselvi84 commented Jul 21, 2023

google-oss-prow bot commented Jul 21, 2023

agones-bot commented Jul 21, 2023

agones-bot commented Jul 22, 2023

Kalaiselvi84 commented Jul 19, 2023 •

edited

Loading