Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade site to Google Analytics 4 #3278

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Updating the integration to Google Analytics 4 tags. Was meant to do this a few weeks ago when Universal Analytics forced a migration to GA4.

Thankfully all the data kept being transferred! But this updates to the new JS integration.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Updating the integration to Google Analytics 4 tags. Was meant to do
this a few weeks ago when Universal Analytics forced a migration to GA4.

Thankfully all the data kept being transferred! But this updates to the
new JS integration.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/site The website itself - including redirects, styling, search, etc labels Jul 20, 2023
Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I haven't verified the measurement ID though :)

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey enabled auto-merge (squash) July 20, 2023 00:21
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 20, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 47109a34-5739-4a2c-aa73-7abfdaa3c216

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3278/head:pr_3278 && git checkout pr_3278
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-553d1fb-amd64

@roberthbailey roberthbailey merged commit 71ab422 into googleforgames:main Jul 20, 2023
@markmandel markmandel deleted the site/update-analytics branch July 20, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/site The website itself - including redirects, styling, search, etc kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants