Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestAllocatorAllocateOnGameServerUpdateError #3283

Merged
merged 2 commits into from
Jul 22, 2023
Merged

TestAllocatorAllocateOnGameServerUpdateError #3283

merged 2 commits into from
Jul 22, 2023

Commits on Jul 21, 2023

  1. TestAllocatorAllocateOnGameServerUpdateError 

    This was flaking as the cache is eventually consistent, so sometimes it
wouldn't be populated in time for the allocation request.

Fixed with a better state check on the allocation cache.

```
--- FAIL: TestAllocatorAllocateOnGameServerUpdateError (19.31s)
    allocator_test.go:499:
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:499
        	Error:      	An error is expected but got nil.
        	Test:       	TestAllocatorAllocateOnGameServerUpdateError
```
    @markmandel
    markmandel committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    f48d390 View commit details
    Browse the repository at this point in the history

  2. Attempt 2 to stop this flake.

    @markmandel
    markmandel committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    15a96eb View commit details
    Browse the repository at this point in the history