Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Terraform #3293

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Lumped a couple of things together:

  1. Updated Terraform to the latest release in the build image.
  2. Make a fix to the GKE image that ignores the maintenance policy if the cluster is not on a release channel.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Applied terraform fmt as well.

Lumped a couple of things together:

1. Updated Terraform to the latest release in the build image.
2. Make a fix to the GKE image that ignores the maintenance policy if
the cluster is not on a release channel.
@markmandel markmandel requested a review from gongmax July 28, 2023 20:44
@markmandel markmandel added the area/operations Installation, updating, metrics etc label Jul 28, 2023
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Jul 28, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 47285367-193e-4775-8799-f703d3028265

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Still haven't fixed this unit test flake!

--- FAIL: TestAllocatorAllocateOnGameServerUpdateError (12.71s)
    allocator_test.go:504: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:504
        	Error:      	An error is expected but got nil.
        	Test:       	TestAllocatorAllocateOnGameServerUpdateError

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) July 28, 2023 21:25
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 50b4e919-b14d-4021-82ac-cb92959a9e58

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot removed the lgtm label Jul 31, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c9fb7646-ed51-4d46-b8aa-9e303dab357f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3293/head:pr_3293 && git checkout pr_3293
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-79423a8-amd64

@markmandel markmandel merged commit 034f38a into googleforgames:main Jul 31, 2023
2 checks passed
@markmandel markmandel deleted the build/upgrade-terraform branch July 31, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants