Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake TestAllocatorAllocateOnGameServerUpdateError #3295

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Another attempt to solve this unit test's flakiness.

Also got some extra debugging just in case.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Hopefully this does it, because I'm running out of ideas.

Another attempt to solve this unit test's flakiness.

Also got some extra debugging just in case.
@markmandel markmandel marked this pull request as ready for review July 28, 2023 22:33
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Jul 28, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: abb8895f-69f5-4e60-b48a-ed421324afdc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel enabled auto-merge (squash) July 31, 2023 19:29
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 82a07900-79e6-4f6c-8bf1-ac69d7c6bc02

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3295/head:pr_3295 && git checkout pr_3295
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-1744782-amd64

@markmandel markmandel merged commit 1bffe25 into googleforgames:main Jul 31, 2023
2 checks passed
@markmandel markmandel deleted the flaky/TestAllocatorAllocateOnGameServerUpdateError-take-4 branch July 31, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants