APIService: Updates to handlers for 1.27.x #3297
Conversation
This includes a bug fix for the issue outlined in kubernetes/kubernetes#119662, specifically returning HTTP 406 for root /apis for all requests. Also included an empty OpenAPI v3 discovery document to `/openapi/v3` to stop the regular requests from the K8s control plane, while also bringing the implementation for `/openapi/v2` to be consistent with the new one. Snuck in a linter fix as well. Closes googleforgames#3172
markmandel
added
the
area/user-experience
google-oss-prow
bot
requested review from
EricFortin,
roberthbailey,
aLekSer and
cyriltovena
| @@ -233,7 +233,6 @@ func TestControllerSyncGameServerWithDevIP(t *testing.T) { | |||
| gsFixture.ApplyDefaults() | |||
| gsFixture.Status.State = agonesv1.GameServerStateRequestReady | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
My local linter complained about this. Maybe a newer version?
There was a problem hiding this comment.
Should https://github.com/googleforgames/agones/blob/main/pkg/util/apiserver/apiserver_test.go be updated to test the new endpoints?
Sure, why not. They were really doing a whole lot, but more tests betterer. |
|
Unit tests added! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel, roberthbailey, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: 9ea612c5-a144-482e-b6ae-9e11530f11c1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
This includes a bug fix for the issue outlined in
kubernetes/kubernetes#119662, specifically returning HTTP 406 for root /apis for all requests.
Also included an empty OpenAPI v3 discovery document to
/openapi/v3to stop the regular requests from the K8s control plane, while also bringing the implementation for/openapi/v2to be consistent with the new one.Which issue(s) this PR fixes:
Closes #3172
Special notes for your reviewer:
Snuck in a linter fix as well.