Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky: TestAllocatorAllocateOnGameServerUpdateError #3300

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Okay, I'm trying this one more time, with a slightly different take.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

If anyone else has any other good ideas if this fails again, please jump in!

Okay, I'm trying this one more time, with a slightly different take.
@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Aug 1, 2023
@github-actions github-actions bot added the kind/bug These are bugs. label Aug 1, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bf58ee10-2ef0-41ec-8955-87350c3a360a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3300/head:pr_3300 && git checkout pr_3300
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-1954f5f-amd64

@google-oss-prow google-oss-prow bot removed the lgtm label Aug 1, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f623d04b-c55c-4d0c-ba30-17e1433b38ee

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3300/head:pr_3300 && git checkout pr_3300
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-37884c1-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax gongmax merged commit 19745be into googleforgames:main Aug 1, 2023
2 checks passed
@markmandel markmandel deleted the flaky/TestAllocatorAllocateOnGameServerUpdateError-take-55 branch August 1, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs. lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants