Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate parameter description #3321

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Aug 11, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Fix the inaccurate parameter description according to https://github.com/googleforgames/agones/blob/main/install/helm/agones/templates/service/allocation.yaml#L256-L259

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added the kind/documentation Documentation for Agones label Aug 11, 2023
@gongmax gongmax requested review from markmandel and zmerlynn and removed request for EricFortin and roberthbailey August 11, 2023 17:51
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bf076540-147c-49c9-87f4-187ce8a74002

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

That's a weird flake I haven't seen before:

standard-e2e-test-cluster-1-26

Release "agones" does not exist. Installing it now.
Error: release agones failed, and has been uninstalled due to atomic being set: services "agones-ping-udp-service" not found
make: *** [Makefile:426: install] Error 1

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 72c86d1c-fc88-4d5d-b3ad-d9578a3e267f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3321/head:pr_3321 && git checkout pr_3321
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-195cc92-amd64

@google-oss-prow google-oss-prow bot removed the lgtm label Aug 11, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5bd271ce-f3ba-43e8-aabb-0a68cdc0226a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3321/head:pr_3321 && git checkout pr_3321
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-ef9fe90-amd64

@markmandel markmandel merged commit 614c9ad into googleforgames:main Aug 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants