Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Agones release guide url #3329

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Received a 404 error for the current link to the Agones Release Guide in the Release checklist. Updated it with the correct URL
Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Aug 17, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fc1cc670-04dc-43fa-a91f-4c8a4477155c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3329/head:pr_3329 && git checkout pr_3329
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-5a7ff07-amd64

Copy link
Collaborator

@aimuz aimuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added approved and removed lgtm labels Aug 17, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f1324c11-139b-4f68-b5bb-c1c836409986

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

This seems like a pretty consistent flake in e2e tests.

BOSE: time="2023-08-17 18:52:02.596" level=info msg="RoleBinding 1692298321/agones-sdk-access is created"
VERBOSE: === RUN   TestGameServerResourceValidation
VERBOSE: === PAUSE TestGameServerResourceValidation
VERBOSE: === CONT  TestGameServerResourceValidation
VERBOSE:     gameserver_test.go:953: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserver_test.go:953
VERBOSE:         	Error:      	Not equal: 
VERBOSE:         	            	expected: "spec.template.spec.containers[0].resources.requests[cpu]"
VERBOSE:         	            	actual  : "spec.template.spec.containers[0].resources.requests"
VERBOSE:         	            	
VERBOSE:         	            	Diff:
VERBOSE:         	            	--- Expected
VERBOSE:         	            	+++ Actual
VERBOSE:         	            	@@ -1 +1 @@
VERBOSE:         	            	-spec.template.spec.containers[0].resources.requests[cpu]
VERBOSE:         	            	+spec.template.spec.containers[0].resources.requests
VERBOSE:         	Test:       	TestGameServerResourceValidation
VERBOSE: --- FAIL: TestGameServerResourceValidation (0.59s)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f7a0e86e-5bc7-4904-a129-1e8c001522d6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3329/head:pr_3329 && git checkout pr_3329
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-d55e30c-amd64

@markmandel markmandel merged commit a9c051e into googleforgames:main Aug 17, 2023
2 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the cleanup-release-step branch March 15, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants