Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SDK Conformance error reporting #3331

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Improve SDK Conformance error reporting #3331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81a13e1
Improve SDK Conformance error reporting
markmandel Aug 17, 2023
bee7182
Some cleanup and some extra logging.
markmandel Aug 17, 2023
7a705cf
* Added headers for building
markmandel Aug 17, 2023
999c785
Merge branch 'main' into update/better-sdk-conformance-reporting
zmerlynn Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions build/includes/sdk.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,13 @@ run-sdk-conformance-no-build: ensure-build-sdk-image
run-sdk-conformance-test: TRIES=5
run-sdk-conformance-test: ensure-agones-sdk-image
run-sdk-conformance-test: ensure-build-sdk-image
@echo "\n\n^^^ Building: $(SDK_FOLDER)\n\n"
$(MAKE) run-sdk-command COMMAND=build-sdk-test
for try in `seq 1 $(TRIES)`; do \
$(MAKE) run-sdk-conformance-no-build && echo "+++ Success: $(SDK_FOLDER)" && break || \
status=$$? && echo "*** Failure: $(SDK_FOLDER), try $$try/$(TRIES)"; \
done; (exit $$status)
@for try in `seq 1 $(TRIES)`; do \
echo "\n\n>>> Starting: ($$try/$(TRIES)) $(SDK_FOLDER)\n\n" && \
$(MAKE) run-sdk-conformance-no-build && echo "\n\n+++ Success: ($$try/$(TRIES)) $(SDK_FOLDER)\n\n" && break || \
echo "\n\n*** Failure: ($$try/$(TRIES)) $(SDK_FOLDER)\n\n" && false; \
done

run-sdk-conformance-test-cpp:
$(MAKE) run-sdk-conformance-test SDK_FOLDER=cpp GRPC_PORT=9003 HTTP_PORT=9103
Expand Down
2 changes: 1 addition & 1 deletion cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ steps:
- cpp-sdk-build-restore-cache
- ensure-build-sdk-image-base
dir: "build"
args: [ "-j", "4", "--output-sync=target", "build-sdks"]
args: [ "-j", "4", "--output-sync=recurse", "build-sdks"]

#
# Cache the cpp sdk build directory, to speed up subsequent builds (considerably)
Expand Down
Loading