Update release checklist #3334

Kalaiselvi84 · 2023-08-21T17:15:44Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

agones-bot · 2023-08-21T18:16:49Z

Build Succeeded 👏

Build Id: fac3f538-3d13-46bc-aa60-95c00e4dfe66

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://01ce648-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3334/head:pr_3334 && git checkout pr_3334
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-01ce648-amd64

agones-bot · 2023-08-22T00:24:07Z

Build Succeeded 👏

Build Id: 2b29c565-f4b0-4bed-ac56-76ec388aec3e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://39691be-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3334/head:pr_3334 && git checkout pr_3334
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-39691be-amd64

Kalaiselvi84 · 2023-08-22T21:08:33Z

I will follow the same approach for the helm commands that you mentioned in the other PR to create a .sh file for the Rust SDK.

agones-bot · 2023-08-22T22:41:33Z

Build Succeeded 👏

Build Id: 89912b34-b8b1-42f3-bae2-bf1d859476f1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://3965047-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3334/head:pr_3334 && git checkout pr_3334
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-3965047-amd64

…4/agones into update-rel-checklist

agones-bot · 2023-08-23T01:19:42Z

Build Succeeded 👏

Build Id: 7d3ece2a-2163-4a93-8f5a-8fc51c9bc766

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://cb54d84-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3334/head:pr_3334 && git checkout pr_3334
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-cb54d84-amd64

Kalaiselvi84 · 2023-08-23T16:50:54Z

@markmandel, I've included a shell script and a target to run the necessary helm commands for Agones update after you approve this PR. Also modified the release process based on the change. Could you please review the latest changes?

If any of the helm commands fail during the release process, the failed and remaining steps will be handled manually. Does this sound good?

markmandel

Looks good, just some ideas on naming and some possible cleanup 👍🏻

markmandel · 2023-08-24T21:15:30Z

build/Makefile

@@ -856,3 +856,10 @@ test-gen-crd-client:
 		echo "$$diff_output"; \
 	fi

+update-agones: $(ensure-build-image)


Suggested change

update-agones: $(ensure-build-image)

install-release: $(ensure-build-image)

Maybe, as a better name?

modified here and other locations as well

markmandel · 2023-08-24T21:15:51Z

build/Makefile

+	docker run -it --rm \
+		$(common_mounts) \
+		-w $(workdir_path) \
+		-e "KUBECONFIG=/root/.kube/$(kubeconfig_file)" \


Suggested change

-e "KUBECONFIG=/root/.kube/$(kubeconfig_file)" \

Is this line required? I feel like it should be where it looks by default 🤔

excluded this line

markmandel · 2023-08-24T21:16:26Z

build/Makefile

+update-agones: $(ensure-build-image)
+	docker run -it --rm \
+		$(common_mounts) \
+		-w $(workdir_path) \


Suggested change

-w $(workdir_path) \

Given that this is all helm commands - probably doesn't need to be in a specific work dir?

removed this line

markmandel

Looks good! Need to move it out of draft though please 😄

google-oss-prow · 2023-08-24T22:19:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-08-24T23:55:10Z

Build Succeeded 👏

Build Id: 27290b95-99b1-4b65-b82d-1a6b38e6c62d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://8572d1c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3334/head:pr_3334 && git checkout pr_3334
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-8572d1c-amd64

google-oss-prow · 2023-08-25T17:11:17Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-08-25T18:31:45Z

Build Failed 😱

Build Id: e8c63aa3-9d06-4742-a695-790fdfd78286

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-26T00:57:54Z

Build Succeeded 👏

Build Id: b41aeba1-2410-4e1b-af0d-391eb8e9804e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ee37487-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3334/head:pr_3334 && git checkout pr_3334
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-ee37487-amd64

aimuz · 2023-08-26T03:46:00Z

build/Makefile

+	docker run -it --rm \
+		$(common_mounts) \
+		$(DOCKER_RUN_ARGS) \
+		$(build_tag) /go/src/agones.dev/agones/build/install-release.sh


Can you add a new blank line here?

agones-bot · 2023-08-29T17:21:11Z

Build Succeeded 👏

Build Id: df73b796-868e-45cc-a963-457a29017d8e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://d625a4e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3334/head:pr_3334 && git checkout pr_3334
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-d625a4e-amd64

agones-bot · 2023-08-29T18:44:19Z

Build Succeeded 👏

Build Id: f3eed2fc-cde5-43ab-81a0-6b675329e0df

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://c11704e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3334/head:pr_3334 && git checkout pr_3334
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-c11704e-amd64

agones-bot · 2023-09-06T23:03:30Z

Build Succeeded 👏

Build Id: 6234402d-11c1-42ee-9e4b-6e540e9fc530

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://4df375b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3334/head:pr_3334 && git checkout pr_3334
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-4df375b-amd64

Update release checklist

01ce648

Kalaiselvi84 requested a review from markmandel August 21, 2023 17:15

google-oss-prow bot added the size/XS label Aug 21, 2023

github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Aug 21, 2023

google-oss-prow bot requested a review from roberthbailey August 21, 2023 17:16

markmandel approved these changes Aug 21, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Aug 21, 2023

google-oss-prow bot added the lgtm label Aug 21, 2023

Merge branch 'main' into update-rel-checklist

39691be

google-oss-prow bot added approved and removed lgtm labels Aug 21, 2023

markmandel enabled auto-merge (squash) August 22, 2023 19:28

markmandel approved these changes Aug 22, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Aug 22, 2023

Merge branch 'main' into update-rel-checklist

3965047

google-oss-prow bot removed the lgtm label Aug 22, 2023

Kalaiselvi84 marked this pull request as draft August 22, 2023 21:04

auto-merge was automatically disabled August 22, 2023 21:04
Pull request was converted to draft

google-oss-prow bot added the do-not-merge/work-in-progress label Aug 22, 2023

Kalaiselvi84 added 2 commits August 22, 2023 23:03

Create script for helm commands

0ada83f

Merge branch 'update-rel-checklist' of https://github.com/Kalaiselvi8…

e812fd2

…4/agones into update-rel-checklist

google-oss-prow bot added size/M and removed size/XS labels Aug 22, 2023

Merge branch 'main' into update-rel-checklist

cb54d84

markmandel reviewed Aug 24, 2023

View reviewed changes

Kalaiselvi84 added 2 commits August 24, 2023 21:30

suggested changes

663bbe2

Merge branch 'main' into update-rel-checklist

8572d1c

markmandel approved these changes Aug 24, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Aug 24, 2023

Kalaiselvi84 marked this pull request as ready for review August 24, 2023 22:20

google-oss-prow bot removed the do-not-merge/work-in-progress label Aug 24, 2023

google-oss-prow bot requested review from aLekSer and markmandel August 24, 2023 22:20

Merge branch 'main' into update-rel-checklist

cb3e66e

google-oss-prow bot removed the lgtm label Aug 25, 2023

Merge branch 'main' into update-rel-checklist

ee37487

aimuz reviewed Aug 26, 2023

View reviewed changes

Kalaiselvi84 added 3 commits August 29, 2023 16:07

Merge branch 'main' into update-rel-checklist

c0610ae

new line added

39c9960

modified sh file

d625a4e

one more new line

c11704e

markmandel enabled auto-merge (squash) September 6, 2023 19:28

Merge branch 'main' into update-rel-checklist

4df375b

markmandel merged commit e5ce5ab into googleforgames:main Sep 6, 2023
2 checks passed

Kalaiselvi84 deleted the update-rel-checklist branch March 15, 2024 01:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update release checklist #3334

Update release checklist #3334

Kalaiselvi84 commented Aug 21, 2023

agones-bot commented Aug 21, 2023

agones-bot commented Aug 22, 2023

Kalaiselvi84 commented Aug 22, 2023

agones-bot commented Aug 22, 2023

agones-bot commented Aug 23, 2023

Kalaiselvi84 commented Aug 23, 2023 •

edited

Loading

markmandel left a comment

markmandel Aug 24, 2023

Kalaiselvi84 Aug 24, 2023

markmandel Aug 24, 2023

Kalaiselvi84 Aug 24, 2023

markmandel Aug 24, 2023

Kalaiselvi84 Aug 24, 2023

markmandel left a comment

google-oss-prow bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

google-oss-prow bot commented Aug 25, 2023

agones-bot commented Aug 25, 2023

agones-bot commented Aug 26, 2023

aimuz Aug 26, 2023

agones-bot commented Aug 29, 2023

agones-bot commented Aug 29, 2023

agones-bot commented Sep 6, 2023

	update-agones: $(ensure-build-image)
	install-release: $(ensure-build-image)

Update release checklist #3334

Update release checklist #3334

Conversation

Kalaiselvi84 commented Aug 21, 2023

agones-bot commented Aug 21, 2023

agones-bot commented Aug 22, 2023

Kalaiselvi84 commented Aug 22, 2023

agones-bot commented Aug 22, 2023

agones-bot commented Aug 23, 2023

Kalaiselvi84 commented Aug 23, 2023 • edited Loading

markmandel left a comment

Choose a reason for hiding this comment

markmandel Aug 24, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Aug 24, 2023

Choose a reason for hiding this comment

markmandel Aug 24, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Aug 24, 2023

Choose a reason for hiding this comment

markmandel Aug 24, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Aug 24, 2023

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Aug 24, 2023

agones-bot commented Aug 24, 2023

google-oss-prow bot commented Aug 25, 2023

agones-bot commented Aug 25, 2023

agones-bot commented Aug 26, 2023

aimuz Aug 26, 2023

Choose a reason for hiding this comment

agones-bot commented Aug 29, 2023

agones-bot commented Aug 29, 2023

agones-bot commented Sep 6, 2023

Kalaiselvi84 commented Aug 23, 2023 •

edited

Loading