Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site-server target #3335

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Fix site-server target #3335

merged 4 commits into from
Aug 22, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3169

Special notes for your reviewer:

@google-oss-prow google-oss-prow bot requested a review from aLekSer August 21, 2023 22:05
@github-actions github-actions bot added the kind/bug These are bugs. label Aug 21, 2023
@markmandel
Copy link
Member

oooh fancy!

@roberthbailey you dug into this somewhat, did you wanna take a look?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d8971984-8c90-4bfb-8828-7a4de821c8cc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3335/head:pr_3335 && git checkout pr_3335
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-eb60a66-amd64

@@ -23,12 +23,14 @@
#
# Website targets
#
UID := $(shell id -u)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You could also use the below variation as well.
UID != id -u
GID != id -g

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delayed response. Your suggestion seems reasonable. May we proceed with your recommendation?

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Aug 22, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@markmandel markmandel enabled auto-merge (squash) August 22, 2023 19:28
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8e6ca42e-826e-4f04-b765-cd48837fdcfa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3335/head:pr_3335 && git checkout pr_3335
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-34821a3-amd64

@markmandel markmandel merged commit 857030b into googleforgames:main Aug 22, 2023
3 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the pr_3169 branch March 15, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make site-server is failing with a git error about dubious ownership of files
4 participants