Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch up C++ SDK to make gen-all-sdk-grpc #3337

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

zmerlynn
Copy link
Collaborator

We need to keep an eye on what changed here so we can understand if we need to make this hermetic, but with this diff fixed we should be able to submit #3310.

We need to keep an eye on what changed here so we can understand if we
need to make this hermetic, but with this diff fixed we should be able
to submit googleforgames#3310.
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it passes 😃🤞🏻

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn enabled auto-merge (squash) August 21, 2023 23:59
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0e78c95e-f267-4351-86be-4cac07941aea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3337/head:pr_3337 && git checkout pr_3337
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-bdc9c62-amd64

@zmerlynn zmerlynn merged commit b98c46b into googleforgames:main Aug 22, 2023
3 checks passed
@zmerlynn zmerlynn deleted the clean-3310 branch August 22, 2023 14:31
@Kalaiselvi84 Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants