restapi generation: clean before generation so we don't leak files #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esn't leak files Without this change, if `restapi` generates a file previously and then you run generation again and the file is _not_ generated, the old file will still be there. This then results in the `header` script adding the boilerplate a second time, resulting a diff every time. Along the way: the boilerplate is still 2022
|
Build Succeeded 👏 Build Id: b0b38da5-cbae-43d2-824a-91ad2b7376cd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
steven-supersolid
approved these changes
Aug 30, 2023
gongmax
approved these changes
Sep 5, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, steven-supersolid, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, if
restapigenerates a file previously and then you run generation again and the file is not generated, the old file will still be there. This then results in theheaderscript adding the boilerplate a second time, resulting a diff every time.Along the way: the boilerplate is still 2022
Note to reviewer: the second commit is the re-generation with new boilerplate.