Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unaccurate progress description of HA Agones #3364

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Sep 7, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Update the document of HA Agones to reflect all phases are in.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added the kind/documentation Documentation for Agones label Sep 7, 2023
@gongmax gongmax requested review from zmerlynn and removed request for markmandel and cyriltovena September 7, 2023 17:01
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f0aeb94f-aa23-41be-8844-a6b1708a5ee4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3364/head:pr_3364 && git checkout pr_3364
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-62762c8-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) September 7, 2023 23:32
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Sep 7, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 30bb66b7-5f00-43ac-bf21-694af53c6bb6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3364/head:pr_3364 && git checkout pr_3364
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-f5d8d46-amd64

@markmandel markmandel merged commit 8f1f2b5 into googleforgames:main Sep 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants