Update: Allocation Overflow Documentation #3368

Kalaiselvi84 · 2023-09-08T20:50:56Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Fix documentation bugs in allocationOverflow documentation.

Which issue(s) this PR fixes:

Closes #3361

Special notes for your reviewer:

agones-bot · 2023-09-08T21:51:41Z

Build Succeeded 👏

Build Id: 59cd6021-0c32-4adb-bc51-7c06bb276233

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://3fd66d3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-3fd66d3-amd64

markmandel · 2023-09-12T00:27:02Z

Looks good!

Can we also add a line to https://agones.dev/site/docs/guides/fleet-updates/#notifying-gameservers-on-fleet-updatedownscale specifying:

The labels and/or annotations are applied to GameServers in a Fleet in the order designated by their configured Fleet scheduling.

I think the best place for this is here:

agones/site/content/en/docs/Guides/fleet-updates.md

Line 150 in 9deb15f

I think that should cover things.

agones-bot · 2023-09-12T05:34:13Z

Build Succeeded 👏

Build Id: b29ee068-ffe5-4412-9069-3180c53ee936

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://c7c483b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-c7c483b-amd64

markmandel

Almost there 👍🏻

site/content/en/docs/Guides/fleet-updates.md

agones-bot · 2023-09-12T21:08:08Z

Build Succeeded 👏

Build Id: d93bb547-f674-4920-afbe-2cb1bd4aacd0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://cae172f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-cae172f-amd64

markmandel · 2023-09-12T21:12:07Z

site/content/en/docs/Guides/fleet-updates.md

@@ -147,6 +147,8 @@ This provides two useful capabilities:
 2. This can also be used to proactively update `GameServer` labels, to effect change in allocation strategy - such as 
   preferring the newer `GameServers` when allocating, but falling back to the older version if there aren't enough 
   of the new ones yet spun up.
+
+The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}})


Suggested change

The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}})

The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}}).

Small final nit!

agones-bot · 2023-09-12T22:28:04Z

Build Succeeded 👏

Build Id: 5f56c46c-0d6d-4d4b-8855-be5a4feb70da

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://927fa6c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-927fa6c-amd64

google-oss-prow · 2023-09-12T22:32:36Z

New changes are detected. LGTM label has been removed.

google-oss-prow · 2023-09-12T22:32:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-09-12T23:40:33Z

Build Succeeded 👏

Build Id: 78344229-721c-4acb-9f6f-9384a3ffe8d5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ebb5de3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-ebb5de3-amd64

Update: Allocation Overflow Documentation

3fd66d3

Kalaiselvi84 requested a review from markmandel September 8, 2023 20:50

google-oss-prow bot requested a review from aLekSer September 8, 2023 20:50

google-oss-prow bot added the size/XS label Sep 8, 2023

github-actions bot added the kind/documentation Documentation for Agones label Sep 8, 2023

Kalaiselvi84 added 2 commits September 12, 2023 03:55

Merge branch 'main' into overflow

54a72c6

updated fleet document

c7c483b

google-oss-prow bot added size/S and removed size/XS labels Sep 12, 2023

markmandel reviewed Sep 12, 2023

View reviewed changes

site/content/en/docs/Guides/fleet-updates.md Outdated Show resolved Hide resolved

Kalaiselvi84 added 2 commits September 12, 2023 19:24

\n added

ad825f1

Merge branch 'main' into overflow

cae172f

markmandel reviewed Sep 12, 2023

View reviewed changes

small nit

927fa6c

markmandel approved these changes Sep 12, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Sep 12, 2023

google-oss-prow bot added the lgtm label Sep 12, 2023

markmandel enabled auto-merge (squash) September 12, 2023 22:32

Merge branch 'main' into overflow

ebb5de3

google-oss-prow bot removed the lgtm label Sep 12, 2023

google-oss-prow bot added the approved label Sep 12, 2023

markmandel merged commit 963fb15 into googleforgames:main Sep 12, 2023
2 checks passed

Kalaiselvi84 deleted the overflow branch March 15, 2024 01:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update: Allocation Overflow Documentation #3368

Update: Allocation Overflow Documentation #3368

Kalaiselvi84 commented Sep 8, 2023 •

edited by markmandel

Loading

agones-bot commented Sep 8, 2023

markmandel commented Sep 12, 2023

agones-bot commented Sep 12, 2023

markmandel left a comment

agones-bot commented Sep 12, 2023

markmandel Sep 12, 2023

agones-bot commented Sep 12, 2023

google-oss-prow bot commented Sep 12, 2023

google-oss-prow bot commented Sep 12, 2023

agones-bot commented Sep 12, 2023

	The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}})
	The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}}).

Update: Allocation Overflow Documentation #3368

Update: Allocation Overflow Documentation #3368

Conversation

Kalaiselvi84 commented Sep 8, 2023 • edited by markmandel Loading

agones-bot commented Sep 8, 2023

markmandel commented Sep 12, 2023

agones-bot commented Sep 12, 2023

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Sep 12, 2023

markmandel Sep 12, 2023

Choose a reason for hiding this comment

agones-bot commented Sep 12, 2023

google-oss-prow bot commented Sep 12, 2023

google-oss-prow bot commented Sep 12, 2023

agones-bot commented Sep 12, 2023

Kalaiselvi84 commented Sep 8, 2023 •

edited by markmandel

Loading