-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Go SDK client Counter functions #3372
Adds Go SDK client Counter functions #3372
Conversation
Build Succeeded 👏 Build Id: 269b9eb4-6493-4923-92ac-d835165a375b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great, just a note on whether we need that method, and if possible, we don't need to update the date on all the CRD apis?
cf44593
to
2a6cbe2
Compare
Build Failed 😱 Build Id: b2f9f595-3b5b-478e-aeac-11b5c2de25ce To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
041ce80
to
c834a24
Compare
Build Succeeded 👏 Build Id: 0c04084e-e825-4285-bd20-b50b03a110b3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igooch, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: af231055-76fd-4893-b92c-68b7127e2e5e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Implements the Go SDK client Counter functions
Which issue(s) this PR fixes:
Working on #2716
Special notes for your reviewer: