-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes TestGameServerResourceValidation flake #3373
Fixes TestGameServerResourceValidation flake #3373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emphatic approval!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, igooch, markmandel, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 73a25f7a-8572-4bda-bcde-044ea09a1093 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Fixes TestGameServerResourceValidation flaky test by sorting the returned errors for a deterministic result.
Which issue(s) this PR fixes:
Closes #3362
Special notes for your reviewer: