Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps simple-game-server version to 0.18 #3379

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ KIND_PROFILE ?= agones
KIND_CONTAINER_NAME=$(KIND_PROFILE)-control-plane

# Game Server image to use while doing end-to-end tests
GS_TEST_IMAGE ?= us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
GS_TEST_IMAGE ?= us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18

# Enable all alpha feature gates. Keep in sync with `false` (alpha) entries in pkg/util/runtime/features.go:featureDefaults
ALPHA_FEATURE_GATES ?= "PlayerAllocationFilter=true&PlayerTracking=true&CountsAndLists=true&FleetAllocationOverflow=true&Example=true"
Expand Down
2 changes: 1 addition & 1 deletion examples/crd-client/create-gs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ spec:
imagePullPolicy: Always
env:
- name: GAMESERVER_IMAGE
value: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
value: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
restartPolicy: Never
2 changes: 1 addition & 1 deletion examples/fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,4 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
2 changes: 1 addition & 1 deletion examples/gameserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
imagePullPolicy: Always
# nodeSelector is a label that can be used to tell Kubernetes which host
# OS to use. For Windows game servers uncomment the nodeSelector
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/dev-gameserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
2 changes: 1 addition & 1 deletion examples/simple-game-server/fleet-distributed.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
resources:
requests:
memory: 64Mi
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/fleet-tcp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
env:
# Disables the UDP listener (Enabled by default)
- name: UDP
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
resources:
requests:
memory: 64Mi
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/gameserver-passthrough.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
env:
- name: PASSTHROUGH
value: 'TRUE'
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/gameserver-windows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
resources:
requests:
memory: 64Mi
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/gameserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
resources:
requests:
memory: 64Mi
Expand Down
2 changes: 1 addition & 1 deletion install/helm/agones/templates/tests/test-runner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
imagePullPolicy: Always
env:
- name: GAMESERVER_IMAGE
value: "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17"
value: "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18"
- name: IS_HELM_TEST
value: "true"
- name: GAMESERVERS_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/webhooks/webhooks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func TestWebHookFleetValidationHandler(t *testing.T) {
"template": {
"spec": {
"containers": [{
"image": "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17",
"image": "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18",
"name": false
}]
}
Expand Down
2 changes: 1 addition & 1 deletion site/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ dev_eks_example_cluster_version = "1.27"
dev_minikube_example_cluster_version = "1.26.6"

# example tag
example_image_tag = "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17"
example_image_tag = "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18"

# Enable syntax highlighting and copy buttons on code blocks with Prism
prism_syntax_highlighting = true
Expand Down
22 changes: 11 additions & 11 deletions site/content/en/docs/Guides/fleet-updates.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,25 +129,25 @@ the rate that you deem fit for your specific rollout.

{{< alpha title="Allocated GameSever Overflow Notification" gate="FleetAllocationOverflow" >}}

When `Allocated` `GameServers` are utilised for a long time, such as a Lobby `GameServer`,
or a `GameServer` that is being reused multiple times in a row, it can be useful
to notify an `Allocated` `GameServer` process when its backing Fleet has been updated.
When an update occurs, the `Allocated` `GameServer`, may want to actively perform a graceful shutdown and release its
When `Allocated` `GameServers` are utilised for a long time, such as a Lobby `GameServer`,
or a `GameServer` that is being reused multiple times in a row, it can be useful
to notify an `Allocated` `GameServer` process when its backing Fleet has been updated.
When an update occurs, the `Allocated` `GameServer`, may want to actively perform a graceful shutdown and release its
resources such that it can be replaced by a new version, or similar actions.

To do this, we provide the ability to apply a user-provided set of labels and/or annotations to the `Allocated`
To do this, we provide the ability to apply a user-provided set of labels and/or annotations to the `Allocated`
`GameServers` when a `Fleet` update occurs that updates its `GameServer` template, or generally
causes the `Fleet` replica count to drop below the number of currently `Allocated` `GameServers`.
causes the `Fleet` replica count to drop below the number of currently `Allocated` `GameServers`.

This provides two useful capabilities:

1. The `GameServer` [`SDK.WatchGameServer()`]({{% relref "./Client SDKs/_index.md#watchgameserverfunctiongameserver" %}})
command can be utilised to react to this annotation and/or label change to
command can be utilised to react to this annotation and/or label change to
indicate the Fleet system change, and the game server binary could execute code accordingly.
2. This can also be used to proactively update `GameServer` labels, to effect change in allocation strategy - such as
preferring the newer `GameServers` when allocating, but falling back to the older version if there aren't enough
2. This can also be used to proactively update `GameServer` labels, to effect change in allocation strategy - such as
preferring the newer `GameServers` when allocating, but falling back to the older version if there aren't enough
of the new ones yet spun up.

The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}}).

Example yaml configuration:
Expand All @@ -174,7 +174,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: gcr.io/agones-images/simple-game-server:0.13
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
```

See the [Fleet reference]({{% relref "../Reference/fleet.md" %}}) for more details.
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/framework/framework.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func NewFromFlags() (*Framework, error) {
}

viper.SetDefault(kubeconfigFlag, filepath.Join(usr.HomeDir, ".kube", "config"))
viper.SetDefault(gsimageFlag, "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17")
viper.SetDefault(gsimageFlag, "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18")
viper.SetDefault(pullSecretFlag, "")
viper.SetDefault(stressTestLevelFlag, 0)
viper.SetDefault(perfOutputDirFlag, "")
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/gameserver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ spec:
preferredDuringSchedulingIgnoredDuringExecution: ERROR
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
`
err := os.WriteFile("/tmp/invalid.yaml", []byte(gsYaml), 0o644)
require.NoError(t, err)
Expand Down
2 changes: 1 addition & 1 deletion test/load/allocation/fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
spec:
containers:
- args: [-automaticShutdownDelaySec=600]
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
name: simple-game-server
resources:
limits:
Expand Down
2 changes: 1 addition & 1 deletion test/load/allocation/scenario-fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
value: 'true'
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.17
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.18
args: [-automaticShutdownDelaySec=60, -readyIterations=10]
resources:
limits:
Expand Down