Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Fleet and GameServerSet CRDs #3396

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Updates Fleet and GameServerSet CRDs #3396

merged 3 commits into from
Sep 21, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Sep 21, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Changes the Status for Counters and Lists to match the same structure as AggregatedCounterStatus and AggregatedListStatus in common.go

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@igooch
Updates Fleet and GameServerSet CRDs
654d28f 
Changes the Status for Counters and Lists to match the same structure as AggregatedCounterStatus and AggregatedListStatus in common.go
@github-actions github-actions bot added the kind/feature New features for Agones label Sep 21, 2023
@igooch
Generated Files
e3c8cd6
@igooch
Adds AllocatedCapacity and AllocatedCount to the fleet controller
831419a 
Adds tests for AllocatedCount and AllocatedCapacity on the Fleet controller
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 99567010-bd97-4e14-84c3-dce709431454

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5dbf5325-1e79-4ef2-81da-59c134a158e9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 43f5a01e-9fc0-42f7-a459-558144c5949a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3396/head:pr_3396 && git checkout pr_3396
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-831419a-amd64

@igooch igooch marked this pull request as ready for review September 21, 2023 19:50
markmandel
markmandel approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-oss-prow google-oss-prow bot added the lgtm label Sep 21, 2023
@markmandel markmandel merged commit e77d5cc into googleforgames:main Sep 21, 2023
2 checks passed
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@markmandel markmandel

Labels
approved kind/feature New features for Agones lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igooch @agones-bot @markmandel