Adds GameServerAllocation e2e tests for Counters #3400

igooch · 2023-09-25T18:27:29Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds GameServerAllocation filtering e2e test for Counters
Adds GameServerAllocation sorting e2e test for Counters
Adds GameServerAllocation CounterActions e2e test for Counters
Updates Fleet and GameServer e2e tests to delete the fleet after test run
Adds Counters to GameServerAllocation example
Changes GameServer UpdateCount logic to truncate requests rather than a no-op for increment or decrement requests that go above capacity or below zero
Changes UpdateCounterCapacity in gameserver.go to update Count to equal Capacity when Capacity is set to a value less than Count

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

agones-bot · 2023-09-25T19:29:39Z

Build Succeeded 👏

Build Id: 29f8e288-b08b-4d50-b50f-9212e6b900a5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://667db26-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3400/head:pr_3400 && git checkout pr_3400
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-667db26-amd64

agones-bot · 2023-09-28T01:15:17Z

Build Failed 😱

Build Id: 0b3ae335-76e7-438b-a7f4-686b26da7f4c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

test/e2e/gameserverallocation_test.go

agones-bot · 2023-09-28T16:13:35Z

Build Failed 😱

Build Id: 2a401516-8290-4c5c-8735-ec1cef6399b0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-09-28T19:10:34Z

Build Failed 😱

Build Id: dce14fbb-85c8-4dc4-bcd7-8454f2886638

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-09-29T14:50:00Z

Build Failed 😱

Build Id: 4563a346-316b-4b41-9cc1-ad747fc29bd2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-02T17:50:02Z

Build Failed 😱

Build Id: 9a95ff43-acaa-472c-aba4-7083294349af

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-02T20:15:02Z

Build Failed 😱

Build Id: 486fd08f-8360-4e79-84ec-3e195ef562f2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-02T22:08:58Z

Build Succeeded 👏

Build Id: 82902c1f-013a-49b2-b040-278421f0108c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ac7a600-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3400/head:pr_3400 && git checkout pr_3400
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-ac7a600-amd64

agones-bot · 2023-10-03T00:31:56Z

Build Failed 😱

Build Id: d1ae921d-c5bd-4995-b60a-4cdaefb440f3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-03T01:10:50Z

Build Failed 😱

Build Id: 6d5effdb-67a2-4bef-8753-1c8e57e10fd9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-03T02:07:22Z

Build Failed 😱

Build Id: b1492264-a001-49a0-a863-6cab76ff5625

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-03T16:27:47Z

Build Failed 😱

Build Id: 8102f40a-0b7a-4abb-9c83-24067355771f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Updates Fleet and GameServer e2e tests to delete the fleet after test run Adds Counters to GameServerAllocation example

…actions

Now truncates for request that take the Counter below zero or beyond Capacity instead of rejecting the increment or decrement request

Fixes issue where e2e tests was returnting game servers from different fleets

agones-bot · 2023-10-09T19:36:03Z

Build Failed 😱

Build Id: d8571905-2d86-49b5-a751-bc39620c78b5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-09T22:03:14Z

Build Failed 😱

Build Id: 1189229a-fb68-4a7b-8090-fad510d92f2a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

…es less than Count

agones-bot · 2023-10-09T23:11:54Z

Build Succeeded 👏

Build Id: d8af55f2-dc25-447a-875a-59118289238d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://b312b04-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3400/head:pr_3400 && git checkout pr_3400
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-b312b04-amd64

markmandel · 2023-10-09T23:38:32Z

🙌🏻 lemme know when you would like a review 👍🏻

google-oss-prow · 2023-10-11T00:55:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

markmandel · 2023-10-11T00:55:16Z

Looks great!

google-oss-prow bot added do-not-merge/work-in-progress size/M labels Sep 25, 2023

github-actions bot added the kind/feature New features for Agones label Sep 25, 2023

google-oss-prow bot requested review from EricFortin and markmandel September 25, 2023 18:27

google-oss-prow bot added size/XL and removed size/M labels Sep 28, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from a37cefb to 710271a Compare September 28, 2023 15:39

igooch commented Sep 28, 2023

View reviewed changes

test/e2e/gameserverallocation_test.go Show resolved Hide resolved

igooch commented Sep 28, 2023

View reviewed changes

test/e2e/gameserverallocation_test.go Outdated Show resolved Hide resolved

igooch commented Sep 28, 2023

View reviewed changes

test/e2e/gameserverallocation_test.go Outdated Show resolved Hide resolved

igooch force-pushed the arbitrary-counts-lists-2716 branch from a94121a to 710271a Compare September 28, 2023 18:44

google-oss-prow bot added size/XXL and removed size/XL labels Sep 28, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from 7ed2eaf to 89fbcfa Compare September 29, 2023 14:37

igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 3612882 to 8a9a88c Compare October 2, 2023 16:30

igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 8e17c86 to ac7a600 Compare October 2, 2023 20:55

igooch force-pushed the arbitrary-counts-lists-2716 branch from ac7a600 to b65f28c Compare October 2, 2023 23:32

google-oss-prow bot added size/XL and removed size/XXL labels Oct 2, 2023

google-oss-prow bot removed the do-not-merge/work-in-progress label Oct 3, 2023

google-oss-prow bot requested a review from aLekSer October 3, 2023 00:18

igooch force-pushed the arbitrary-counts-lists-2716 branch from 92f2556 to 0fd81fe Compare October 3, 2023 00:56

igooch force-pushed the arbitrary-counts-lists-2716 branch from 0fd81fe to 9d5e269 Compare October 3, 2023 01:23

igooch force-pushed the arbitrary-counts-lists-2716 branch from 9d5e269 to 9e130d9 Compare October 3, 2023 15:56

igooch added 6 commits October 9, 2023 18:53

Adds basic GameServerAllocation e2e test for Counters

117a65c

Updates Fleet and GameServer e2e tests to delete the fleet after test run Adds Counters to GameServerAllocation example

Adds tests for gameserverallocation filterting, sorting, and counter …

1007cfd

…actions

Moving comments so linting passes

ab9cf65

Updates to GameServerAllocation CounterActions tests

f0ba888

Changes UpdateCounter logic for GameServers Counters

fcd260c

Now truncates for request that take the Counter below zero or beyond Capacity instead of rejecting the increment or decrement request

Adds fleet label selector to Counter tests

a5c86d3

Fixes issue where e2e tests was returnting game servers from different fleets

igooch force-pushed the arbitrary-counts-lists-2716 branch from f72514e to a5c86d3 Compare October 9, 2023 18:53

Updates Count to the equal to Capacity when Capacity is set to a valu…

b312b04

…es less than Count

igooch force-pushed the arbitrary-counts-lists-2716 branch from 523c724 to b312b04 Compare October 9, 2023 22:07

markmandel approved these changes Oct 11, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Oct 11, 2023

google-oss-prow bot added the lgtm label Oct 11, 2023

google-oss-prow bot added the approved label Oct 11, 2023

markmandel merged commit e0f859a into googleforgames:main Oct 11, 2023
3 checks passed

igooch mentioned this pull request Jan 18, 2024

Request for igooch to become Approver #3600

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds GameServerAllocation e2e tests for Counters #3400

Adds GameServerAllocation e2e tests for Counters #3400

igooch commented Sep 25, 2023 •

edited

Loading

agones-bot commented Sep 25, 2023

agones-bot commented Sep 28, 2023

agones-bot commented Sep 28, 2023

agones-bot commented Sep 28, 2023

agones-bot commented Sep 29, 2023

agones-bot commented Oct 2, 2023

agones-bot commented Oct 2, 2023

agones-bot commented Oct 2, 2023

agones-bot commented Oct 3, 2023

agones-bot commented Oct 3, 2023

agones-bot commented Oct 3, 2023

agones-bot commented Oct 3, 2023

agones-bot commented Oct 9, 2023

agones-bot commented Oct 9, 2023

agones-bot commented Oct 9, 2023

markmandel commented Oct 9, 2023

google-oss-prow bot commented Oct 11, 2023

markmandel commented Oct 11, 2023

Adds GameServerAllocation e2e tests for Counters #3400

Adds GameServerAllocation e2e tests for Counters #3400

Conversation

igooch commented Sep 25, 2023 • edited Loading

agones-bot commented Sep 25, 2023

agones-bot commented Sep 28, 2023

agones-bot commented Sep 28, 2023

agones-bot commented Sep 28, 2023

agones-bot commented Sep 29, 2023

agones-bot commented Oct 2, 2023

agones-bot commented Oct 2, 2023

agones-bot commented Oct 2, 2023

agones-bot commented Oct 3, 2023

agones-bot commented Oct 3, 2023

agones-bot commented Oct 3, 2023

agones-bot commented Oct 3, 2023

agones-bot commented Oct 9, 2023

agones-bot commented Oct 9, 2023

agones-bot commented Oct 9, 2023

markmandel commented Oct 9, 2023

google-oss-prow bot commented Oct 11, 2023

markmandel commented Oct 11, 2023

igooch commented Sep 25, 2023 •

edited

Loading