Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump simple-game-server references to 0.19 #3439

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Oct 19, 2023

I pushed simple-game-server:0.19 after #3436 was merged, update all references to verify it still works with everything.

Note to reviewers: This was simply:

for f in $(grep -lR simple-game-server:0.18); do
  sed -i "s/simple-game-server:0.18/simple-game-server:0.19/g" $f
done

I double checked this with grep -R simple-game-server | grep 0.18 after, which showed only the changelog.

I pushed simple-game-server:0.19 after googleforgames#3436 was merged, update all
references to verify it still works with everything.
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn enabled auto-merge (squash) October 19, 2023 16:12
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6f4b1e09-83a7-4286-979f-7b1290a3491d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3439/head:pr_3439 && git checkout pr_3439
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-e660011-amd64

@zmerlynn zmerlynn merged commit 34f0463 into googleforgames:main Oct 19, 2023
3 checks passed
@Kalaiselvi84 Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants