Implements UpdateList, AddListValue, and RemoveListValue in the SDK Server #3445

igooch · 2023-10-20T20:22:17Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Implements the List Update (Capacity), Add Value to List, and Remove Value from List in the SDK Server.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

agones-bot · 2023-10-20T20:32:06Z

Build Failed 😱

Build Id: 2c10702c-4ce8-4b1f-beb0-61e3b863645a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-20T20:55:35Z

Build Failed 😱

Build Id: 4e066c23-120d-427d-a0ea-bc66e3eafce2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Generally looks like a good approach - just added some thoughts!

pkg/sdkserver/sdkserver.go

sdks/go/alpha.go

pkg/sdkserver/sdkserver.go

agones-bot · 2023-10-23T19:22:14Z

Build Succeeded 👏

Build Id: 490272b2-6bbc-4726-aefb-a3ed01555849

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://f94120b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3445/head:pr_3445 && git checkout pr_3445
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-f94120b-amd64

agones-bot · 2023-10-24T18:02:44Z

Build Failed 😱

Build Id: 5fa258a6-4f65-408d-a5b6-e89915346dc7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-24T20:35:25Z

Build Failed 😱

Build Id: 0926d964-6d67-405f-9029-d5cfbc980e66

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-24T21:23:51Z

Build Failed 😱

Build Id: 177e0fb8-0795-4c8d-9c22-e44840e391b6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-25T00:39:40Z

Build Failed 😱

Build Id: daf40921-f3df-481b-a450-cce46799e867

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/sdkserver/sdkserver.go

agones-bot · 2023-10-26T18:20:07Z

Build Succeeded 👏

Build Id: 7266d085-8ee5-4246-bc19-aa983fa55299

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://2f12e37-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3445/head:pr_3445 && git checkout pr_3445
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-2f12e37-amd64

agones-bot · 2023-10-26T23:56:05Z

Build Succeeded 👏

Build Id: 40d302dd-39cd-417d-a826-883f8a2b8f38

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://12971d4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3445/head:pr_3445 && git checkout pr_3445
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-12971d4-amd64

markmandel

Getting close I think! Nice stuff!

pkg/apis/agones/v1/gameserver.go

pkg/sdkserver/sdkserver.go

agones-bot · 2023-10-30T18:22:41Z

Build Failed 😱

Build Id: 08b132d7-689a-46eb-840d-44d61044703a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-30T18:42:36Z

Build Failed 😱

Build Id: 81535fe8-5571-41a2-990e-5f1a8e75223d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-30T18:57:56Z

Build Failed 😱

Build Id: 65469614-fa1d-41a2-932b-838cef7c6291

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-30T20:05:05Z

Build Failed 😱

Build Id: 4b378f39-3ffa-46dc-9345-830d8058636f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-30T21:29:28Z

Build Succeeded 👏

Build Id: 0e81bb8b-badf-4ed0-a153-63c089c2ea5b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://1354bd8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3445/head:pr_3445 && git checkout pr_3445
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-1354bd8-amd64

…sting

Adds a const for the List maximum capacity

agones-bot · 2023-10-31T17:57:03Z

Build Failed 😱

Build Id: 715190ac-b5d1-4424-ae69-3d3a5ec695db

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-31T20:02:51Z

Build Succeeded 👏

Build Id: 6a09506a-355f-4087-97b5-da076b9226c8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://66db85c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3445/head:pr_3445 && git checkout pr_3445
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-66db85c-amd64

agones-bot · 2023-11-01T18:07:39Z

Build Succeeded 👏

Build Id: 68a2b04b-31de-4577-956c-dd87a0a9fede

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e59df64-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3445/head:pr_3445 && git checkout pr_3445
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-e59df64-amd64

markmandel

Awesome!

pkg/sdkserver/sdkserver.go

google-oss-prow · 2023-11-01T19:04:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow bot added the do-not-merge/work-in-progress label Oct 20, 2023

google-oss-prow bot requested review from cyriltovena and markmandel October 20, 2023 20:22

google-oss-prow bot added the size/L label Oct 20, 2023

github-actions bot added the kind/feature New features for Agones label Oct 20, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from ac6c418 to 1b7fe27 Compare October 20, 2023 20:40

markmandel reviewed Oct 20, 2023

View reviewed changes

pkg/sdkserver/sdkserver.go Outdated Show resolved Hide resolved

igooch force-pushed the arbitrary-counts-lists-2716 branch 3 times, most recently from 8c47264 to f94120b Compare October 23, 2023 18:23

igooch force-pushed the arbitrary-counts-lists-2716 branch 3 times, most recently from dda41d3 to b622e62 Compare October 24, 2023 17:04

igooch force-pushed the arbitrary-counts-lists-2716 branch from c6bc9af to 34f4403 Compare October 24, 2023 21:00

igooch force-pushed the arbitrary-counts-lists-2716 branch 4 times, most recently from d1cb8f9 to 14dd43a Compare October 24, 2023 23:55

google-oss-prow bot added size/XL and removed size/L labels Oct 24, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from 14dd43a to 0439937 Compare October 25, 2023 00:02

igooch commented Oct 26, 2023

View reviewed changes

pkg/sdkserver/sdkserver.go Show resolved Hide resolved

igooch force-pushed the arbitrary-counts-lists-2716 branch from a39bac1 to 2f12e37 Compare October 26, 2023 17:09

igooch force-pushed the arbitrary-counts-lists-2716 branch from 2f12e37 to 12971d4 Compare October 26, 2023 22:40

markmandel reviewed Oct 27, 2023

View reviewed changes

igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 911aee2 to b72aa70 Compare October 30, 2023 18:41

igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from b67bf72 to 1354bd8 Compare October 30, 2023 19:47

igooch added 4 commits October 31, 2023 16:50

Implements UpdateList, AddValue, and RemoveValue in the SDK Server

825c2f4

Adds SDK Server List Tests

0df2267

Uses GetList within AddListValue and RemoveListValue and adds more te…

d6d341e

…sting

Removes unnecessary error messages when merging two lists

66db85c

Adds a const for the List maximum capacity

igooch force-pushed the arbitrary-counts-lists-2716 branch from 1354bd8 to 66db85c Compare October 31, 2023 16:50

Merge branch 'main' into arbitrary-counts-lists-2716

e59df64

markmandel approved these changes Nov 1, 2023

View reviewed changes

pkg/sdkserver/sdkserver.go Show resolved Hide resolved

pkg/sdkserver/sdkserver.go Show resolved Hide resolved

google-oss-prow bot assigned markmandel Nov 1, 2023

google-oss-prow bot added the lgtm label Nov 1, 2023

google-oss-prow bot added the approved label Nov 1, 2023

markmandel merged commit 91112fd into googleforgames:main Nov 1, 2023
3 checks passed

igooch mentioned this pull request Jan 18, 2024

Request for igooch to become Approver #3600

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implements UpdateList, AddListValue, and RemoveListValue in the SDK Server #3445

Implements UpdateList, AddListValue, and RemoveListValue in the SDK Server #3445

igooch commented Oct 20, 2023

agones-bot commented Oct 20, 2023

agones-bot commented Oct 20, 2023

markmandel left a comment

agones-bot commented Oct 23, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 25, 2023

agones-bot commented Oct 26, 2023

agones-bot commented Oct 26, 2023

markmandel left a comment

agones-bot commented Oct 30, 2023

agones-bot commented Oct 30, 2023

agones-bot commented Oct 30, 2023

agones-bot commented Oct 30, 2023

agones-bot commented Oct 30, 2023

agones-bot commented Oct 31, 2023

agones-bot commented Oct 31, 2023

agones-bot commented Nov 1, 2023

markmandel left a comment

google-oss-prow bot commented Nov 1, 2023

Implements UpdateList, AddListValue, and RemoveListValue in the SDK Server #3445

Implements UpdateList, AddListValue, and RemoveListValue in the SDK Server #3445

Conversation

igooch commented Oct 20, 2023

agones-bot commented Oct 20, 2023

agones-bot commented Oct 20, 2023

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Oct 23, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 25, 2023

agones-bot commented Oct 26, 2023

agones-bot commented Oct 26, 2023

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Oct 30, 2023

agones-bot commented Oct 30, 2023

agones-bot commented Oct 30, 2023

agones-bot commented Oct 30, 2023

agones-bot commented Oct 30, 2023

agones-bot commented Oct 31, 2023

agones-bot commented Oct 31, 2023

agones-bot commented Nov 1, 2023

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Nov 1, 2023