Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples/autoscaler-webook dependencies #3447

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

This resolve the dependabot issue (#3421) with dependencies, and also updates the example image version.

Which issue(s) this PR fixes:

Resolving issue with #3421

Special notes for your reviewer:

This will fail on first run, since I haven't updated the prod image. If we see no issues with the PR, then I'll push the image up and rerun.

Also this was the example that IntelliJ was always updating, so it'll stop me having to work around not committing the change 😃

@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 20, 2023
Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0dee5936-904e-4859-b2f9-fde3d6ddf21e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Also a weird flake

Already have image: e2e-runner
PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=false&PodHostname=false&SplitControllerAndExtensions=false&FleetAllocationOverflow=true&CountsAndLists=true&Example=true
Fetching cluster endpoint and auth data.
ERROR: (gcloud.container.clusters.get-credentials) ResponseError: code=404, message=Not found: projects/agones-images/locations/us-central1/clusters/standard-e2e-test-cluster-1-25.
No cluster named 'standard-e2e-test-cluster-1-25' in agones-images.

@gongmax
Copy link
Collaborator

gongmax commented Oct 23, 2023

Also a weird flake

Already have image: e2e-runner
PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=false&PodHostname=false&SplitControllerAndExtensions=false&FleetAllocationOverflow=true&CountsAndLists=true&Example=true
Fetching cluster endpoint and auth data.
ERROR: (gcloud.container.clusters.get-credentials) ResponseError: code=404, message=Not found: projects/agones-images/locations/us-central1/clusters/standard-e2e-test-cluster-1-25.
No cluster named 'standard-e2e-test-cluster-1-25' in agones-images.

Kalai was recreating the test clusters last Friday that introduced this flake

@markmandel
Copy link
Member Author

Aha, I wondered.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b8eb2804-2f19-46a4-9e12-0c3f67b40004

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Oct 25, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b553ea67-2640-4745-87e3-5b725cb9d443

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

This resolve the dependabot issue with dependencies, and also updates
the example image version.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a70c282b-91a5-4df5-9607-0d341a07361f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3447/head:pr_3447 && git checkout pr_3447
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-e6d6f46-amd64

@markmandel markmandel merged commit 4061ee7 into googleforgames:main Oct 27, 2023
3 checks passed
@markmandel markmandel deleted the examples/autoscaler-deps branch October 27, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants