-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples/autoscaler-webook dependencies #3447
Update examples/autoscaler-webook dependencies #3447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build Failed 😱 Build Id: 0dee5936-904e-4859-b2f9-fde3d6ddf21e To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Also a weird flake
|
Kalai was recreating the test clusters last Friday that introduced this flake |
Aha, I wondered. |
Build Failed 😱 Build Id: b8eb2804-2f19-46a4-9e12-0c3f67b40004 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: b553ea67-2640-4745-87e3-5b725cb9d443 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This resolve the dependabot issue with dependencies, and also updates the example image version.
d867d55
to
e6d6f46
Compare
Build Succeeded 👏 Build Id: a70c282b-91a5-4df5-9607-0d341a07361f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
This resolve the dependabot issue (#3421) with dependencies, and also updates the example image version.
Which issue(s) this PR fixes:
Resolving issue with #3421
Special notes for your reviewer:
This will fail on first run, since I haven't updated the prod image. If we see no issues with the PR, then I'll push the image up and rerun.
Also this was the example that IntelliJ was always updating, so it'll stop me having to work around not committing the change 😃