Update Supported Kubernetes to 1.26, 1.27, 1.28 #3450

Kalaiselvi84 · 2023-10-23T20:55:32Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #3371

Special notes for your reviewer:

…rver@v0.27.6

agones-bot · 2023-10-23T22:01:50Z

Build Succeeded 👏

Build Id: 55e366cf-fe1e-473b-9583-7bf005157f8b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://0aa88bd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3450/head:pr_3450 && git checkout pr_3450
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-0aa88bd-amd64

gongmax

Did you perform step "Regenerate Kubernetes resource includes (e.g. ObjectMeta, PodTemplateSpec)"? I didn't see any change for ObjectMeta and PodTemplateSpec.

gongmax · 2023-10-23T23:16:52Z

pkg/gameserverallocations/allocator_test.go

@@ -81,6 +81,7 @@ func TestAllocatorAllocate(t *testing.T) {

 	require.NoError(t, a.Run(ctx))
 	// wait for it to be up and running
+	// nolint:staticcheck
 	err := wait.PollImmediate(time.Second, 10*time.Second, func() (done bool, err error) {


I saw you fixed this lint warning with PollUntilContextTimeout which looks correct. Do you mind fix these too? We can also do this in a separate PR. Up to you.

sure, will replace all PollImmediate with PollUntilContextTimeout.

I've replaced PollImmediate with PollUntilContextTimeout.
Is it fine to replace wait.Poll(time.Second, 10*time.Second, func() (bool, error) with wait.PollUntilContextTimeout(ctx, time.Second, 10*time.Second, true, func(ctx context.Context) (bool, error))?

Yes, wait.Poll can be replaced with wait.PollUntilContextTimeout. Again, up to you whether do that in this PR or a following up PR.

gongmax · 2023-10-23T23:17:09Z

pkg/gameserverallocations/allocator.go

@@ -692,6 +692,7 @@ func Retry(backoff wait.Backoff, fn func() error) error {
 			return false, nil
 		}
 	})
+	// nolint:staticcheck


Let's create an issue to track the fix.

Kalaiselvi84 · 2023-10-24T01:16:35Z

Did you perform step "Regenerate Kubernetes resource includes (e.g. ObjectMeta, PodTemplateSpec)"? I didn't see any change for ObjectMeta and PodTemplateSpec.

Yes, I've executed this step, and within this PR, neither _io.k8s.api.core.v1.PodTemplateSpec.yaml nor _io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta.yaml were modified.
These two files were previously altered by the PR related to the Go script conversion. For reference, I set up the 1.27 cluster before this conversion took place.

agones-bot · 2023-10-24T03:07:13Z

Build Succeeded 👏

Build Id: e1c15609-451a-4dbb-8b50-241dcf84ad69

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://2524a0a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3450/head:pr_3450 && git checkout pr_3450
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-2524a0a-amd64

agones-bot · 2023-10-24T03:51:41Z

Build Failed 😱

Build Id: 5b74f521-a757-4020-b818-305c95d0fef6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-24T04:26:43Z

Build Failed 😱

Build Id: 6eddc291-731e-45e1-8fca-92ca1fe351ba

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-24T05:49:03Z

Build Failed 😱

Build Id: 9a4439d7-632e-49a2-8079-3f670ba0b39d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-10-24T18:50:36Z

Build Succeeded 👏

Build Id: 0697fc53-cd79-49e2-bb40-224279f746b2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://daa231d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3450/head:pr_3450 && git checkout pr_3450
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-daa231d-amd64

gongmax

There are some deprecated methods can be replaced. But I'm totally fine to fix it in a following PR if you prefer.

gongmax · 2023-10-24T20:26:15Z

pkg/sdkserver/sdkserver.go

@@ -295,6 +295,7 @@ func (s *SDKServer) WaitForConnection(ctx context.Context) error {
 	}

 	try := 0
+	// nolint:staticcheck
 	return wait.PollImmediateInfiniteWithContext(ctx, 4*time.Second, func(ctx context.Context) (bool, error) {


This can also be replaced with PollUntilContextCancel

gongmax · 2023-10-24T20:29:34Z

test/e2e/framework/framework.go

@@ -292,6 +292,7 @@ func (f *Framework) WaitForGameServerState(t *testing.T, gs *agonesv1.GameServer
 // Each Allocated GameServer gets deleted allocDuration after it was Allocated.
 // GameServers will continue to be Allocated until a message is passed to the done channel.
 func (f *Framework) CycleAllocations(ctx context.Context, t *testing.T, flt *agonesv1.Fleet, period time.Duration, allocDuration time.Duration) {
+	// nolint:staticcheck
 	err := wait.PollImmediateUntil(period, func() (bool, error) {


This can also be replaced with PollUntilContextCancel

google-oss-prow · 2023-10-24T20:35:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, Kalaiselvi84
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Kalaiselvi84 · 2023-10-24T20:43:20Z

There are some deprecated methods can be replaced. But I'm totally fine to fix it in a following PR if you prefer.

Will create a separate PR for this fix😅

Kalaiselvi84 added 6 commits October 20, 2023 21:04

version update in 12 files before make gen-api-docs

0be1f9e

change in k8s verison from 1.27.7 to 1.27.6 and make gen-api-docs

3a1ae1a

make gen-crd-client

2b66e29

site-config.toml update

8a67577

go get k8s.io/client-go@v0.27.6 and go get k8s.io/apiextensions-apise…

49763ac

…rver@v0.27.6

update from cluster creation step

0aa88bd

Kalaiselvi84 requested a review from gongmax October 23, 2023 20:55

google-oss-prow bot requested review from aLekSer and roberthbailey October 23, 2023 20:55

google-oss-prow bot added the size/XXL label Oct 23, 2023

github-actions bot added the kind/breaking Breaking change label Oct 23, 2023

gongmax reviewed Oct 23, 2023

View reviewed changes

replace PollImmediate with PollUntilContextTimeout in few go files

2524a0a

more replacement of PollImmediate with PollUntilContextTimeout

3dac555

Kalaiselvi84 and others added 3 commits October 24, 2023 17:14

Replaced wait.Poll with wait.PollUntilContextTimeout

db3bcea

update sdkserver_test.go

b25f025

Merge branch 'main' into version-update-k8s

daa231d

gongmax approved these changes Oct 24, 2023

View reviewed changes

google-oss-prow bot assigned gongmax Oct 24, 2023

google-oss-prow bot added the lgtm label Oct 24, 2023

gongmax merged commit ace74f6 into googleforgames:main Oct 24, 2023
3 checks passed

Kalaiselvi84 deleted the version-update-k8s branch March 15, 2024 01:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Supported Kubernetes to 1.26, 1.27, 1.28 #3450

Update Supported Kubernetes to 1.26, 1.27, 1.28 #3450

Kalaiselvi84 commented Oct 23, 2023 •

edited

Loading

agones-bot commented Oct 23, 2023

gongmax left a comment

gongmax Oct 23, 2023

Kalaiselvi84 Oct 24, 2023

Kalaiselvi84 Oct 24, 2023

gongmax Oct 24, 2023

gongmax Oct 23, 2023

Kalaiselvi84 commented Oct 24, 2023 •

edited

Loading

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

gongmax left a comment

gongmax Oct 24, 2023

gongmax Oct 24, 2023

google-oss-prow bot commented Oct 24, 2023

Kalaiselvi84 commented Oct 24, 2023

Update Supported Kubernetes to 1.26, 1.27, 1.28 #3450

Update Supported Kubernetes to 1.26, 1.27, 1.28 #3450

Conversation

Kalaiselvi84 commented Oct 23, 2023 • edited Loading

agones-bot commented Oct 23, 2023

gongmax left a comment

Choose a reason for hiding this comment

gongmax Oct 23, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Oct 24, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Oct 24, 2023

Choose a reason for hiding this comment

gongmax Oct 24, 2023

Choose a reason for hiding this comment

gongmax Oct 23, 2023

Choose a reason for hiding this comment

Kalaiselvi84 commented Oct 24, 2023 • edited Loading

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

agones-bot commented Oct 24, 2023

gongmax left a comment

Choose a reason for hiding this comment

gongmax Oct 24, 2023

Choose a reason for hiding this comment

gongmax Oct 24, 2023

Choose a reason for hiding this comment

google-oss-prow bot commented Oct 24, 2023

Kalaiselvi84 commented Oct 24, 2023

Kalaiselvi84 commented Oct 23, 2023 •

edited

Loading

Kalaiselvi84 commented Oct 24, 2023 •

edited

Loading