Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and push system image before performance tests #3454

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Build and push system image before performance tests #3454

merged 4 commits into from
Oct 26, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Oct 25, 2023 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Build and push the agones system images before kicking off the performance tests, so the performance tests can use those images to install Agones on testing clusters.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 419c5caa-ac59-4e43-b576-0c523794b7c6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8af23422-eedf-4bb0-9f34-16a257d45ed5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Oct 25, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a0483ddb-0630-47f6-827a-666d92b898b5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 51b30c47-34c2-49c3-baca-12b98926568b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5a3cd260-5a13-4e6a-b809-16e831e8e3a1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b5bf2b3c-87d8-449d-adac-b058f0555f13

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5d1e630a-0d30-4d2b-841b-ddab92bab803

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 371139b6-0335-484c-b5c1-454e3c0a4a48

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3454/head:pr_3454 && git checkout pr_3454
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-6c093fe-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 29e95997-0143-4376-b72e-87ad84bea2ef

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 374ad0ee-61f6-46d1-9dbb-0092c6ef2428

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@gongmax gongmax changed the title Build and push image before performance tests Build and push system image before performance tests Oct 26, 2023
@gongmax gongmax marked this pull request as ready for review October 26, 2023 05:01
@gongmax gongmax requested review from zmerlynn and removed request for cyriltovena and aLekSer October 26, 2023 05:01
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 85097576-e312-4bf6-8f7e-274fb88e3f96

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 397afab5-f029-4cd0-bbfe-e634c090df83

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4e19a452-67ce-4c8a-b387-fdcc0ddb6287

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e0467b84-971d-4e58-973d-b1aa7bde06da

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added the lgtm label Oct 26, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn merged commit 8e3bb74 into googleforgames:main Oct 26, 2023
3 checks passed
@Kalaiselvi84 Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn zmerlynn approved these changes

@markmandel markmandel Awaiting requested review from markmandel

Assignees

@zmerlynn zmerlynn

Labels
kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gongmax @agones-bot @zmerlynn @Kalaiselvi84