Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable deletion protection for Autopilot test clusters #3468

Merged
merged 19 commits into from
Dec 16, 2023
Merged

Disable deletion protection for Autopilot test clusters #3468

merged 19 commits into from
Dec 16, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Oct 27, 2023 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Seems deletion protection is enabled by default for AP clusters, and we saw cluster couldn't be deleted when we updated k8s version for test clusters. This PR disable it explicitly.
Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@gongmax gongmax marked this pull request as ready for review October 27, 2023 18:25
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 27, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 70940d30-6636-4e3f-aa7d-d255f2e100bb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-c6a0871-amd64

@roberthbailey
Copy link
Member

This is changing the value is the terraform module, which changes it for both the test clusters but also for anyone that is using our example module: https://github.com/googleforgames/agones/blob/main/examples/terraform-submodules/gke-autopilot/module.tf

I think it would make more sense to make it a variable, set it to true by default (to keep the current behavior) and set it to false explicitly in the test configs.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c96ac5f9-70f6-4c25-ad90-ca2dd7f5129c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0231c7b5-101b-4001-b093-cd7a4bbabea6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4ee335ff-5608-4225-a49a-4d860a940400

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b695520e-7c63-45b3-a273-45769e51cadd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-0974180-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3ce6182a-fe61-455b-b57d-ceb10fcc24c4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-64b24cb-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 18b7e9c9-3284-407d-8776-0a9a5b24dfb6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 41f0cf14-5ad0-422d-b74c-ee002c95fc56

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d630507e-2a1d-45b1-a3a1-a1149f5bd92c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-96a3d0a-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1314672e-97b2-4b17-b654-15631deb2722

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-1b3869a-amd64

@gongmax gongmax mentioned this pull request Nov 11, 2023
Merged
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 71473818-e5bc-4432-a103-63226cfe728c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-ffdddc8-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 16079928-0d22-44cd-9d39-46459f02b030

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-e0bed80-amd64

@Kalaiselvi84
Copy link
Contributor

Are we good to merge this PR?

@google-oss-prow google-oss-prow bot added the lgtm label Dec 1, 2023
@google-oss-prow google-oss-prow bot removed the lgtm label Dec 1, 2023
@google-oss-prow Google OSS Prow
Copy link

New changes are detected. LGTM label has been removed.

zmerlynn
zmerlynn requested changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@zmerlynn zmerlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. One thing I realized for both this and maintenance exclusions is that we injected it into the install/terraform path. I don't think that's right - I think maintenance exclusions should be optional in the base install and we need this in the e2e specific one. Unless I'm mis-remembering the structure here?

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax
Once this PR has been reviewed and has the lgtm label, please assign alekser for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5c74820c-d304-4689-a0e1-356e4bf1588c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-e140659-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4d785c88-17c9-4d7c-bf9d-0799e0ebc50c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@gongmax
Copy link
Collaborator Author

gongmax commented Dec 14, 2023

Wait. One thing I realized for both this and maintenance exclusions is that we injected it into the install/terraform path. I don't think that's right - I think maintenance exclusions should be optional in the base install and we need this in the e2e specific one. Unless I'm mis-remembering the structure here?

Make sense. Updated accordingly.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: eeec2056-e117-4ad9-a94f-d3bb110531e9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e910af95-dd97-4ea7-870b-039d51d363af

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-550c5bf-amd64

@zmerlynn zmerlynn enabled auto-merge (squash) December 15, 2023 23:38
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ec31fcb4-230b-4a9b-b994-494a2dc18315

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3468/head:pr_3468 && git checkout pr_3468
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-9a0039f-amd64

@zmerlynn zmerlynn merged commit a193a5a into googleforgames:main Dec 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn zmerlynn approved these changes

@markmandel markmandel Awaiting requested review from markmandel

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@zmerlynn zmerlynn

Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gongmax @agones-bot @roberthbailey @Kalaiselvi84 @zmerlynn