Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Go SDK Client List Functions #3484

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Nov 1, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds Go client functions for List

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Nov 1, 2023
sdks/go/alpha.go Show resolved Hide resolved
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from c7f8894 to 88023d2 Compare November 1, 2023 20:37
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sdks/go/alpha.go Show resolved Hide resolved
auto-merge was automatically disabled November 1, 2023 21:21

Head branch was pushed to by a user without write access

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 88023d2 to a835edf Compare November 1, 2023 21:21
@google-oss-prow google-oss-prow bot removed the lgtm label Nov 1, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e13f4233-bd19-448c-bf81-652d77855fcd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3484/head:pr_3484 && git checkout pr_3484
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-a835edf-amd64

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit a205436 into googleforgames:main Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants