Add Shulker to the Agones adopters list #3503

jeremylvln · 2023-11-13T09:19:59Z

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
I work on a side-project named Shulker, a Kubernetes operator for managing Minecraft infrastructures. It heavily uses Agones behind the scene to provision the game servers. Honestly this project couldn't existed without Agones, so first, thank you for your work.

I take my chance to submit a backlink to my work by adding an entry in the "Integrations with other projects" section of the examples page. Let me know if this was the wrong place, or if you do not want this kind of entries in the documntation :)

Which issue(s) this PR fixes:

Closes #N/A

Special notes for your reviewer:

N/A

agones-bot · 2023-11-13T10:32:03Z

Build Succeeded 👏

Build Id: de4f03fe-65ec-40e1-ba8d-1508c5002b7e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e4128b2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3503/head:pr_3503 && git checkout pr_3503
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-e4128b2-amd64

markmandel · 2023-11-13T22:26:57Z

Thanks for your submission! We would love to have it, but can you put it in:

https://github.com/googleforgames/agones/blob/main/site/content/en/docs/Third%20Party%20Content/examples.md

That's where we put third part / non official examples. Thanks!

jeremylvln · 2023-11-14T09:45:50Z

Thanks for your submission! We would love to have it, but can you put it in:

https://github.com/googleforgames/agones/blob/main/site/content/en/docs/Third%20Party%20Content/examples.md

That's where we put third part / non official examples. Thanks!

Thanks for the feedback! I updated the PR :)

agones-bot · 2023-11-14T10:50:42Z

Build Succeeded 👏

Build Id: e5cdb84d-72a4-4ef5-b3da-96c4cd448e3b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://2e2ca45-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3503/head:pr_3503 && git checkout pr_3503
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-2e2ca45-amd64

agones-bot · 2023-11-15T09:54:54Z

Build Succeeded 👏

Build Id: 0496fdb3-1f79-4e20-949c-2e5a0d54385e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://8b8a74e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3503/head:pr_3503 && git checkout pr_3503
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-8b8a74e-amd64

agones-bot · 2023-11-15T11:17:49Z

Build Succeeded 👏

Build Id: a06cab46-8284-43ca-b1d1-496a5fd5bca6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://65f4f93-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3503/head:pr_3503 && git checkout pr_3503
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-65f4f93-amd64

markmandel

Sorry! I had a review, and never hit submit! My apologies!!!

markmandel · 2023-11-14T21:05:25Z

site/content/en/docs/Third Party Content/examples.md

+- It achieves high availability and density Minecraft infrastructures as long as Agones is just as much.
+
+Shulker requires you to have a genuine Minecraft account. You'll need to purchase the game to test


Nit: "genuine" seem redundant 😃 an account is an account.

Suggested change

Shulker requires you to have a genuine Minecraft account. You'll need to purchase the game to test

Shulker requires you to have a Minecraft account. You'll need to purchase the game to test

Suggestion: Link "minecraft account" to the correct webpage where this happens? (I don't play minecraft, so I've no idea what this might entail).

Historically, "hacked" Minecraft account were always tolerated. Today, I must say, they represent quite a lot of the player community of Minecraft. It's very common for Minecraft servers to explicitly say that only genuine accounts are accepted. It may be surprising, but I think being explicit here is necessary.

Aaah - interesting context! That makes sense, I wasn't aware of that.

I think a link would be good though, just for context - to here? https://www.minecraft.net/en-us/login ? or here? https://www.minecraft.net/en-us/article/how-create-minecraft-account (for those of us who are not familiar with minecraft).

Yup, that's a good idea. Fixed.

site/content/en/docs/Third Party Content/examples.md

Signed-off-by: Jérémy Levilain <jeremy@jeremylvln.fr>

agones-bot · 2023-11-24T17:26:14Z

Build Failed 😱

Build Id: 76c0217f-6e76-49d9-b2c8-575c6ffaafe1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-11-27T23:56:50Z

I think we may have to mark the link https://www.minecraft.net/en-us/article/how-create-minecraft-account as a link we don't test, since it seems to dislike bots, but I'll run it again and see how it goes.

agones-bot · 2023-11-28T00:48:52Z

Build Failed 😱

Build Id: 2b3904f6-ed40-4875-b045-2b8d9626c4a4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Third Party Content/examples.md

Co-authored-by: Mark Mandel <markmandel@google.com>

agones-bot · 2023-11-28T09:19:25Z

Build Failed 😱

Build Id: 6c485471-e41a-4de0-a490-0572f7c2e130

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

jeremylvln · 2023-11-28T09:30:54Z

I looked at the build logs and I failed to see something relevant for the error. Running make site-static locally work like a charm

markmandel · 2023-11-28T18:43:44Z

Looks like a unit test flake.

{"message":"Wait for cache sync","severity":"info","time":"2023-11-28T09:16:39.329961074Z"}
{"message":"Wait for cache sync","severity":"info","time":"2023-11-28T09:16:39.331206441Z"}
{"message":"agones.dev/agones/pkg/client/informers/externalversions/factory.go:134: Failed to watch *v1.GameServer: unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}}","severity":"error","time":"2023-11-28T09:16:39.347115092Z"}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2577702]

goroutine 167 [running]:
agones.dev/agones/pkg/gameserversets.(*AllocationOverflowController).Run(0x0, {0x2dff5e8, 0xc000230990})
	/go/src/agones.dev/agones/pkg/gameserversets/allocation_overflow.go:98 +0x42
agones.dev/agones/pkg/gameserversets.(*Controller).Run.func1()
	/go/src/agones.dev/agones/pkg/gameserversets/controller.go:194 +0x85
created by agones.dev/agones/pkg/gameserversets.(*Controller).Run
	/go/src/agones.dev/agones/pkg/gameserversets/controller.go:193 +0x33b

agones-bot · 2023-11-28T20:06:38Z

Build Succeeded 👏

Build Id: 5823c483-11f1-4ea8-8ec0-17ae69fd74ff

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://a8b8f69-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3503/head:pr_3503 && git checkout pr_3503
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-a8b8f69-amd64

markmandel

Let's go!

google-oss-prow · 2023-11-28T20:26:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremylvln, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-11-28T20:26:19Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-11-28T21:41:14Z

Build Succeeded 👏

Build Id: 3bd9b7a7-4e78-49ab-8832-8288bb250b4c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://4c37a9d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3503/head:pr_3503 && git checkout pr_3503
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-4c37a9d-amd64

google-oss-prow bot requested review from aLekSer and cyriltovena November 13, 2023 09:20

google-oss-prow bot added the size/XS label Nov 13, 2023

github-actions bot added the kind/documentation Documentation for Agones label Nov 13, 2023

jeremylvln force-pushed the patch-1 branch from 83a42a4 to e4128b2 Compare November 13, 2023 09:24

jeremylvln force-pushed the patch-1 branch from e4128b2 to df7b54c Compare November 14, 2023 09:43

google-oss-prow bot added size/S and removed size/XS labels Nov 14, 2023

jeremylvln force-pushed the patch-1 branch from df7b54c to 2e2ca45 Compare November 14, 2023 09:45

jeremylvln force-pushed the patch-1 branch from 2e2ca45 to 8b8a74e Compare November 15, 2023 08:55

jeremylvln force-pushed the patch-1 branch from 8b8a74e to 65f4f93 Compare November 15, 2023 10:14

markmandel reviewed Nov 17, 2023

View reviewed changes

Add Shulker to the Agones adopters list

f18a3b7

Signed-off-by: Jérémy Levilain <jeremy@jeremylvln.fr>

jeremylvln force-pushed the patch-1 branch from 65f4f93 to f18a3b7 Compare November 24, 2023 16:31

markmandel reviewed Nov 28, 2023

View reviewed changes

site/content/en/docs/Third Party Content/examples.md Outdated Show resolved Hide resolved

Exclude Minecraft how-to link from dead-link check

a8b8f69

Co-authored-by: Mark Mandel <markmandel@google.com>

markmandel approved these changes Nov 28, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Nov 28, 2023

google-oss-prow bot added the lgtm label Nov 28, 2023

google-oss-prow bot added the approved label Nov 28, 2023

Merge branch 'main' into patch-1

4c37a9d

google-oss-prow bot removed the lgtm label Nov 28, 2023

markmandel enabled auto-merge (squash) November 28, 2023 20:26

markmandel merged commit a8e5931 into googleforgames:main Nov 28, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Shulker to the Agones adopters list #3503

Add Shulker to the Agones adopters list #3503

jeremylvln commented Nov 13, 2023

agones-bot commented Nov 13, 2023

markmandel commented Nov 13, 2023

jeremylvln commented Nov 14, 2023

agones-bot commented Nov 14, 2023

agones-bot commented Nov 15, 2023

agones-bot commented Nov 15, 2023

markmandel left a comment

markmandel Nov 14, 2023

jeremylvln Nov 21, 2023

markmandel Nov 21, 2023

jeremylvln Nov 24, 2023

agones-bot commented Nov 24, 2023

markmandel commented Nov 27, 2023

agones-bot commented Nov 28, 2023

agones-bot commented Nov 28, 2023

jeremylvln commented Nov 28, 2023

markmandel commented Nov 28, 2023

agones-bot commented Nov 28, 2023

markmandel left a comment

google-oss-prow bot commented Nov 28, 2023

google-oss-prow bot commented Nov 28, 2023

agones-bot commented Nov 28, 2023

		- It achieves high availability and density Minecraft infrastructures as long as Agones is just as much.

		Shulker requires you to have a genuine Minecraft account. You'll need to purchase the game to test

	Shulker requires you to have a genuine Minecraft account. You'll need to purchase the game to test
	Shulker requires you to have a Minecraft account. You'll need to purchase the game to test

Add Shulker to the Agones adopters list #3503

Add Shulker to the Agones adopters list #3503

Conversation

jeremylvln commented Nov 13, 2023

agones-bot commented Nov 13, 2023

markmandel commented Nov 13, 2023

jeremylvln commented Nov 14, 2023

agones-bot commented Nov 14, 2023

agones-bot commented Nov 15, 2023

agones-bot commented Nov 15, 2023

markmandel left a comment

Choose a reason for hiding this comment

markmandel Nov 14, 2023

Choose a reason for hiding this comment

jeremylvln Nov 21, 2023

Choose a reason for hiding this comment

markmandel Nov 21, 2023

Choose a reason for hiding this comment

jeremylvln Nov 24, 2023

Choose a reason for hiding this comment

agones-bot commented Nov 24, 2023

markmandel commented Nov 27, 2023

agones-bot commented Nov 28, 2023

agones-bot commented Nov 28, 2023

jeremylvln commented Nov 28, 2023

markmandel commented Nov 28, 2023

agones-bot commented Nov 28, 2023

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Nov 28, 2023

google-oss-prow bot commented Nov 28, 2023

agones-bot commented Nov 28, 2023