Fixes occasional data race flake with TestSDKServerAddListValue #3505
Conversation
Puts gsListUpdates call after the mutex lock
|
Build Succeeded 👏 Build Id: 672b9ce0-d81a-4739-9924-c0c8bc554060 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| @@ -1175,10 +1175,11 @@ func (s *SDKServer) updateList(ctx context.Context) error { | |||
| } | |||
| gsCopy := gs.DeepCopy() | |||
|
|
|||
| s.logger.WithField("batchListUpdates", s.gsListUpdates).Debug("Batch updating List(s)") | |||
There was a problem hiding this comment.
That would do it! Nice catch.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igooch, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 9ed2b41d-bcbc-41ad-9827-04fbeed8f421 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Fixes occasional data race flake with TestSDKServerAddListValue by putting the s.gsListUpdates call in the logger after the mutex lock.
Which issue(s) this PR fixes:
NA
Special notes for your reviewer: