Move FleetAllocationOverflow to Beta #3515

Kalaiselvi84 · 2023-11-16T22:55:40Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3514

Special notes for your reviewer:

agones-bot · 2023-11-16T23:57:59Z

Build Succeeded 👏

Build Id: c31c58bf-1720-4eea-b990-60689508da38

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e1e8edb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3515/head:pr_3515 && git checkout pr_3515
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-e1e8edb-amd64

markmandel · 2023-11-17T23:39:22Z

Looks good -

I had a search for FleetAllocationOverflow and found a few more adjustments to make:

agones/site/content/en/docs/Reference/fleet.md

Lines 46 to 47 in 065052a

    
           # [Stage:Alpha] 
        
           # [FeatureFlag:FleetAllocationOverflow]

agones/pkg/apis/agones/v1/fleet.go

Lines 62 to 67 in 065052a

    
           // [Stage: Alpha] 
        
           // [FeatureFlag:FleetAllocationOverflow] 
        
           // Labels and/or Annotations to apply to overflowing GameServers when the number of Allocated GameServers is more 
        
           // than the desired replicas on the underlying `GameServerSet` 
        
           // +optional 
        
           AllocationOverflow *AllocationOverflow `json:"allocationOverflow,omitempty"`

agones/pkg/apis/agones/v1/gameserverset.go

Lines 62 to 67 in 065052a

    
           // [Stage: Alpha] 
        
           // [FeatureFlag:FleetAllocationOverflow] 
        
           // Labels and Annotations to apply to GameServers when the number of Allocated GameServers drops below 
        
           // the desired replicas on the underlying `GameServerSet` 
        
           // +optional 
        
           AllocationOverflow *AllocationOverflow `json:"allocationOverflow,omitempty"`

agones/examples/fleet.yaml

Lines 53 to 63 in 065052a

    
           # [Stage:Alpha] 
        
           # [FeatureFlag:FleetAllocationOverflow] 
        
           # Labels and/or Annotations to apply to overflowing GameServers when the number of Allocated GameServers exceeds 
        
           # the desired replicas in the underlying `GameServerSet` 
        
           # Commented out since Alpha, and disabled by default 
        
           # allocationOverflow: 
        
           #   labels: 
        
           #     mykey: myvalue 
        
           #     version: ""  # empty an existing label value 
        
           #   annotations: 
        
           #     otherkey: setthisvalue

(This one can be uncommented)

If you could also do a search to triple check please, make sure I didn't miss anything else - that would be apprecaited!

Kalaiselvi84 · 2023-11-18T01:41:16Z

(This one can be uncommented)

If you could also do a search to triple check please, make sure I didn't miss anything else - that would be apprecaited!

Completed the updates on the specified files, the .md files are now wrapped with the feature shortcodes, and ran make gen-api-docs command to update agones_crd_api_reference.html file.

agones-bot · 2023-11-18T02:33:00Z

Build Failed 😱

Build Id: 5afde00f-c718-4770-889c-ae71cb68de35

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Looks good - just found a very small nit, and then good to merge.

markmandel · 2023-11-21T00:01:13Z

examples/fleet.yaml

-  #     version: ""  # empty an existing label value
-  #   annotations:
-  #     otherkey: setthisvalue
+  # Now in Beta, and can be enabled


Suggested change

# Now in Beta, and can be enabled

# Now in Beta, and enabled by default

markmandel · 2023-11-21T00:02:37Z

Cascading failure on an autopilot cluster - very odd.

agones-bot · 2023-11-21T01:14:52Z

Build Succeeded 👏

Build Id: 0b587f2f-cc55-4e6f-8563-9f5bbd9fa8a7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://4db9aec-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3515/head:pr_3515 && git checkout pr_3515
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-4db9aec-amd64

…vi84/agones into fleetAllocationOverflow

agones-bot · 2023-11-21T05:13:26Z

Build Succeeded 👏

Build Id: 83584b78-cacd-401a-9602-74f8b4a59aa7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://2e317bd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3515/head:pr_3515 && git checkout pr_3515
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-2e317bd-amd64

agones-bot · 2023-11-21T21:07:27Z

Build Succeeded 👏

Build Id: 6b9ecc25-67c0-469c-99f0-51dc51a44a9b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://2078dc8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3515/head:pr_3515 && git checkout pr_3515
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-2078dc8-amd64

google-oss-prow · 2023-11-21T22:07:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Kalaiselvi84 added 2 commits November 16, 2023 22:49

Move FleetAllocationOverflow to Beta

def6c46

small tweak

e1e8edb

Kalaiselvi84 requested a review from markmandel November 16, 2023 22:55

google-oss-prow bot added the do-not-merge/work-in-progress label Nov 16, 2023

Kalaiselvi84 marked this pull request as ready for review November 16, 2023 22:55

google-oss-prow bot added size/S and removed do-not-merge/work-in-progress labels Nov 16, 2023

github-actions bot added the kind/other label Nov 16, 2023

google-oss-prow bot requested a review from aLekSer November 16, 2023 22:56

Review changes

d27de83

google-oss-prow bot added size/XXL and removed size/S labels Nov 18, 2023

Merge branch 'main' into fleetAllocationOverflow

4db9aec

markmandel reviewed Nov 21, 2023

View reviewed changes

Kalaiselvi84 and others added 3 commits November 21, 2023 03:53

review changes

82f6ccc

Merge branch 'fleetAllocationOverflow' of https://github.com/Kalaisel…

4f84ff7

…vi84/agones into fleetAllocationOverflow

Merge branch 'main' into fleetAllocationOverflow

2e317bd

Merge branch 'main' into fleetAllocationOverflow

2078dc8

markmandel approved these changes Nov 21, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Nov 21, 2023

google-oss-prow bot added the lgtm label Nov 21, 2023

markmandel merged commit ddadfe7 into googleforgames:main Nov 21, 2023
3 checks passed

google-oss-prow bot added the approved label Nov 21, 2023

Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Dec 12, 2023

Kalaiselvi84 deleted the fleetAllocationOverflow branch March 15, 2024 01:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move FleetAllocationOverflow to Beta #3515

Move FleetAllocationOverflow to Beta #3515

Kalaiselvi84 commented Nov 16, 2023

agones-bot commented Nov 16, 2023

markmandel commented Nov 17, 2023

Kalaiselvi84 commented Nov 18, 2023

agones-bot commented Nov 18, 2023

markmandel left a comment

markmandel Nov 21, 2023

markmandel commented Nov 21, 2023

agones-bot commented Nov 21, 2023

agones-bot commented Nov 21, 2023

agones-bot commented Nov 21, 2023

google-oss-prow bot commented Nov 21, 2023

	# Now in Beta, and can be enabled
	# Now in Beta, and enabled by default

Move FleetAllocationOverflow to Beta #3515

Move FleetAllocationOverflow to Beta #3515

Conversation

Kalaiselvi84 commented Nov 16, 2023

agones-bot commented Nov 16, 2023

markmandel commented Nov 17, 2023

Kalaiselvi84 commented Nov 18, 2023

agones-bot commented Nov 18, 2023

markmandel left a comment

Choose a reason for hiding this comment

markmandel Nov 21, 2023

Choose a reason for hiding this comment

markmandel commented Nov 21, 2023

agones-bot commented Nov 21, 2023

agones-bot commented Nov 21, 2023

agones-bot commented Nov 21, 2023

google-oss-prow bot commented Nov 21, 2023