Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ResetMetricsOnDelete to Stable #3518

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Move ResetMetricsOnDelete to Stable #3518

merged 7 commits into from
Nov 22, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3512

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: adf1dced-4832-40a6-8880-f98ca0d29b13

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

General approach looks okay at first glance - lemme know if you need a second pair of eyes.

@Kalaiselvi84
Copy link
Contributor Author

General approach looks okay at first glance - lemme know if you need a second pair of eyes.

We have two tests failing and two passing in controller_test.go after the changes in controller.go. It would be great to get your input on the failing ones:

TestControllerFleetReplicasCount(t *testing.T)
TestControllerFleetAutoScalerState(t *testing.T)

markmandel
markmandel reviewed Nov 22, 2023
View reviewed changes
pkg/metrics/controller_test.go
@@ -292,7 +291,6 @@ func TestControllerGameServersTotal(t *testing.T) {
func TestControllerFleetReplicasCount(t *testing.T) {
runtime.FeatureTestMutex.Lock()
defer runtime.FeatureTestMutex.Unlock()
require.NoError(t, runtime.ParseFeatures(fmt.Sprintf("%s=false", runtime.FeatureResetMetricsOnDelete)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this test was only going to pass when the false was false, the entire test can be deleted.

Copy link
Contributor Author

@Kalaiselvi84 Kalaiselvi84 Nov 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thought, but I was uncertain about the update in the 'controller.go' file.

pkg/metrics/controller_test.go
@@ -399,7 +396,6 @@ func TestControllerFleetReplicasCount_ResetMetricsOnDelete(t *testing.T) {
func TestControllerFleetAutoScalerState(t *testing.T) {
runtime.FeatureTestMutex.Lock()
defer runtime.FeatureTestMutex.Unlock()
require.NoError(t, runtime.ParseFeatures(fmt.Sprintf("%s=false", runtime.FeatureResetMetricsOnDelete)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this test was only going to pass when the false was false, the entire test can be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted the functions.

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Nov 22, 2023
@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review November 22, 2023 19:26
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 76dc9d7d-197d-4b80-ab33-9b305f8313b9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3518/head:pr_3518 && git checkout pr_3518
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-fcbef43-amd64

markmandel
markmandel approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 22, 2023
@markmandel markmandel merged commit 018dc20 into googleforgames:main Nov 22, 2023
3 checks passed
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kalaiselvi84 Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Dec 12, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the ResetMetricsOnDelete branch March 15, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

Labels
approved kind/feature New features for Agones lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move ResetMetricsOnDelete to Stable
3 participants
@Kalaiselvi84 @agones-bot @markmandel